Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: fixes #17296. Fix button directive loading for the new button directives #17295

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

egorbwork
Copy link

@egorbwork egorbwork commented Jan 5, 2025

Defect Fixes

Fixes #17296

Note: It is not best solution but it make it work with new approach.

Egor Boaghi added 2 commits January 5, 2025 13:16
…already created, allowing icon restoration after loading is complete.
Copy link

vercel bot commented Jan 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Updated (UTC)
primeng ⬜️ Ignored (Inspect) Visit Preview Jan 5, 2025 3:14pm
primeng-v18 ⬜️ Ignored (Inspect) Visit Preview Jan 5, 2025 3:14pm

Copy link

vercel bot commented Jan 5, 2025

Someone is attempting to deploy a commit to the primetek Team on Vercel.

A member of the Team first needs to authorize it.

@egorbwork egorbwork changed the title Fix button directive loading for the new button directives Fix: fixes #17296. Fix button directive loading for the new button directives Jan 5, 2025
@mertsincan mertsincan added Status: Pending Review Issue or pull request is being reviewed by Core Team Status: Discussion Issue or pull request needs to be discussed by Core Team labels Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Discussion Issue or pull request needs to be discussed by Core Team Status: Pending Review Issue or pull request is being reviewed by Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loading usage on pButton directive with new directives loses icon
2 participants