-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 114 - filter valid contributions #115
Conversation
chore (merge) - staging to main
Squash UX Bugs
MACI V1 UX Bug Fixes
* feat(cleanup) - refactor and add zkey download, multi ceremony banner * feat(verification) add final beacon and last zkeys * feat(contribution) add warning about changin tabs * feat(cleanup) add login on tutorial and circuit details * chore(syntax)- fix syntax * fix(project) remove .length * fix(firebase) - replace .at with [] * fix(contribute) - stop listener upon timeout * fix(params) fix wrong param name * fix(circuit params) - support legacy firestore field --------- Co-authored-by: ctrlc03 <[email protected]>
* feat(setup) - change S3 path to URL * feat(cleanup) - refactor and add zkey download, multi ceremony banner * feat(verification) add final beacon and last zkeys * feat(contribution) add warning about changin tabs * feat(cleanup) add login on tutorial and circuit details * chore(syntax)- fix syntax * fix(project) remove .length * fix(firebase) - replace .at with [] * fix(contribute) - stop listener upon timeout * fix(params) fix wrong param name * fix(typo) - fix typo * fix(circuit params) - support legacy firestore field * feat(setup) - fix missing params on rln config file --------- Co-authored-by: daodesigner <[email protected]>
chore(license) - add license
* feat(cleanup) - refactor and add zkey download, multi ceremony banner * feat(contribution) add warning about changin tabs * chore(contribute): increase constraints limit (#108)
…ide-specific-ceremonies Hide specific ceremonies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you rebase this brach with dev first please (or just restart from a clean dev checkout branch)? seems like it was checked out from the main branch (where we have been using squash all the time) and adds a number of commits which are confusing the history of dev and perhaps rolling back some code too
* feat(cleanup) - refactor and add zkey download, multi ceremony banner * feat(verification) add final beacon and last zkeys * feat(contribution) add warning about changin tabs * feat(cleanup) add login on tutorial and circuit details * chore(syntax)- fix syntax * fix(project) remove .length * fix(firebase) - replace .at with [] * fix(contribute) - stop listener upon timeout * fix(params) fix wrong param name * fix(circuit params) - support legacy firestore field --------- Co-authored-by: ctrlc03 <[email protected]>
* feat(cleanup) - refactor and add zkey download, multi ceremony banner * feat(contribution) add warning about changin tabs * chore(contribute): increase constraints limit (#108)
…efinitelySetup into issue_114
Visit the preview URL for this PR (updated for commit 3657a74): https://pse-p0tion-staging--preview-348674f45b2398520218eb89de-b1r88cmy.web.app (expires Mon, 22 Apr 2024 00:31:25 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 8c7e9cada78432f8a8ae3f9c611d3e2c03eeadc9 |
⚡️ (Desktop) Lighthouse report for the changes in this PR:
⚡️ (Mobile) Lighthouse report for the changes in this PR:
Lighthouse ran on https://pse-p0tion-staging--preview-348674f45b2398520218eb89de-b1r88cmy.web.app/ |
Glad you spotted that! |
DefinitelySetup Pull Request Template
Title
[Short description of the new ceremony]
Description
Please provide a detailed description of the ceremony you are proposing.
Uploads
Process
./ceremonies/$PREFIX/$CIRCUIT_NAME.$EXTENSION - note that we require both the r1cs and the wasm files.
phase2cli validate --template $PATH_TO_THE_TEMPLATE
Failing to follow the above instructions, will result in the CI checks failing. If all is done accordingly, an administrator will approve and merge your PR and a ceremony will be setup for you.
Ceremony Details
p0tionConfig.json template:
In-details:
Additional Notes
If there are any additional notes, requirements or special instructions related to this ceremony, please specify them here.
Confirmation