-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: publish proof onchain #1279
Conversation
✅ Deploy Preview for maci-typedoc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thanks @0xmad!
Do we know why not? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
- [x] Rollback @zk-kit/baby-jubjub, @zk-kit/eddsa-poseidon, @zk-kit/poseidon-cipher - [x] Wait for commitment update - [x] Add qv flag
49ad758
to
e813174
Compare
Public key serialization is failed because point can't be find on baby-jubjub curve |
I think the error was on deserialization, where a value which previously was invalid, now unpacks to a valid public key - test here https://github.com/privacy-scaling-explorations/maci/blob/dev/domainobjs/ts/__tests__/publicKey.test.ts#L91. I'm debugging this atm. Or was there any other issues you found? |
@ctrlc03 so when I tried to run deploy-poll command for maci-contract, I got Invalid public key, and yes it's related to deserialization. |
would you have a log of the serialized key which caused that? 🙏 |
Yes, it was this one |
Thanks so much!! |
Description
Additional Notes
New
@zk-kit/*
packages are not compatible, rollback them to previous versions.Related issue(s)
Related privacy-scaling-explorations/maci-platform#25
Confirmation