Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: publish proof onchain #1279

Merged
merged 1 commit into from
Mar 8, 2024
Merged

fix: publish proof onchain #1279

merged 1 commit into from
Mar 8, 2024

Conversation

0xmad
Copy link
Collaborator

@0xmad 0xmad commented Mar 7, 2024

Description

  • Rollback @zk-kit/baby-jubjub, @zk-kit/eddsa-poseidon, @zk-kit/poseidon-cipher
  • Wait for commitment update
  • Add qv flag

Additional Notes

New @zk-kit/* packages are not compatible, rollback them to previous versions.

Related issue(s)

Related privacy-scaling-explorations/maci-platform#25

Confirmation

@0xmad 0xmad added the bug Something isn't working label Mar 7, 2024
@0xmad 0xmad self-assigned this Mar 7, 2024
Copy link

netlify bot commented Mar 7, 2024

Deploy Preview for maci-typedoc ready!

Name Link
🔨 Latest commit e813174
🔍 Latest deploy log https://app.netlify.com/sites/maci-typedoc/deploys/65ead3fd69805400082aa083
😎 Deploy Preview https://deploy-preview-1279--maci-typedoc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@samajammin
Copy link
Member

Thanks @0xmad!

New @zk-kit/* packages are not compatible

Do we know why not?

Copy link
Collaborator

@kittybest kittybest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

- [x] Rollback @zk-kit/baby-jubjub, @zk-kit/eddsa-poseidon, @zk-kit/poseidon-cipher
- [x] Wait for commitment update
- [x] Add qv flag
@ctrlc03 ctrlc03 force-pushed the fix/proof-generation branch from 49ad758 to e813174 Compare March 8, 2024 09:01
@ctrlc03 ctrlc03 enabled auto-merge March 8, 2024 09:06
@ctrlc03 ctrlc03 merged commit ea04051 into dev Mar 8, 2024
19 checks passed
@ctrlc03 ctrlc03 deleted the fix/proof-generation branch March 8, 2024 09:17
@0xmad
Copy link
Collaborator Author

0xmad commented Mar 8, 2024

Thanks @0xmad!

New @zk-kit/* packages are not compatible

Do we know why not?

Public key serialization is failed because point can't be find on baby-jubjub curve

@ctrlc03
Copy link
Collaborator

ctrlc03 commented Mar 8, 2024

Thanks @0xmad!

New @zk-kit/* packages are not compatible

Do we know why not?

Public key serialization is failed because point can't be find on baby-jubjub curve

I think the error was on deserialization, where a value which previously was invalid, now unpacks to a valid public key - test here https://github.com/privacy-scaling-explorations/maci/blob/dev/domainobjs/ts/__tests__/publicKey.test.ts#L91. I'm debugging this atm. Or was there any other issues you found?

@0xmad
Copy link
Collaborator Author

0xmad commented Mar 8, 2024

@ctrlc03 so when I tried to run deploy-poll command for maci-contract, I got Invalid public key, and yes it's related to deserialization. @zk-kit/baby-jubjub returns null from unpackPoint method and it caused the error.

@ctrlc03
Copy link
Collaborator

ctrlc03 commented Mar 8, 2024

@ctrlc03 so when I tried to run deploy-poll command for maci-contract, I got Invalid public key, and yes it's related to deserialization. @zk-kit/baby-jubjub returns null from unpackPoint method and it caused the error.

would you have a log of the serialized key which caused that? 🙏

@0xmad
Copy link
Collaborator Author

0xmad commented Mar 8, 2024

Yes, it was this one macipk.2054bb49c5a4038040cb0abc9eaa775714ef378efd60d043b0d763d750e5d20e

@ctrlc03
Copy link
Collaborator

ctrlc03 commented Mar 8, 2024

Yes, it was this one macipk.2054bb49c5a4038040cb0abc9eaa775714ef378efd60d043b0d763d750e5d20e

Thanks so much!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants