Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove redundant init from poll contract #1976

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

ctrlc03
Copy link
Collaborator

@ctrlc03 ctrlc03 commented Dec 23, 2024

Description

Poll init is redundant so it can be removed to simplify the code

(needs #1854 merged first and new anon poll joining artifacts built)

Confirmation

@ctrlc03 ctrlc03 self-assigned this Dec 23, 2024
Copy link

vercel bot commented Dec 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
maci-website ✅ Ready (Inspect) Visit Preview Jan 9, 2025 4:24pm

Copy link
Collaborator

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ctrlc03 thanks, just one question

packages/contracts/contracts/Poll.sol Show resolved Hide resolved
Copy link
Collaborator

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ctrlc03 thanks!

@0xmad 0xmad force-pushed the refactor/remove-poll-init branch from 5af2fcb to d990802 Compare January 9, 2025 16:22
@0xmad 0xmad enabled auto-merge January 9, 2025 16:22
@0xmad 0xmad merged commit 1587632 into dev Jan 9, 2025
23 checks passed
@0xmad 0xmad deleted the refactor/remove-poll-init branch January 9, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants