Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix p5.Color type #6380

Closed

Conversation

asukaminato0721
Copy link
Contributor

addresses p5-types/p5.ts#111

Changes:

fix p5.Color's type to match typescript.

Screenshots of the change:

PR Checklist

@limzykenneth
Copy link
Member

This change does not seem to render correctly in the reference and we'll need to change that before merging this:

Screenshot 2023-08-27 at 17 53 46

@limzykenneth
Copy link
Member

@asukaminato0721 It still looks the same as the screenshot above. You can preview how it render with npm run dev.

@Qianqianye
Copy link
Contributor

Hi @asukaminato0721 @limzykenneth , just following up on this PR. Any thoughts on why it's not rendered properly?

@asukaminato0721 asukaminato0721 marked this pull request as draft October 7, 2023 02:20
@asukaminato0721
Copy link
Contributor Author

asukaminato0721 commented Oct 7, 2023

Hi @asukaminato0721 @limzykenneth , just following up on this PR. Any thoughts on why it's not rendered properly?

I need yui-doc to generator two type signatures for Color's constructor, but https://yui.github.io/yuidoc/syntax/index.html#constructor

A @class tag should be paired with either a @constructor tag or a @static tag.

@asukaminato0721 asukaminato0721 deleted the fix-color-type branch February 12, 2024 07:47
@limzykenneth
Copy link
Member

@asukaminato0721 You might be interested in having a look at #6777. We will be looking into generating typescript definition from the documentation eventually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants