-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add indexing pressure #727
base: master
Are you sure you want to change the base?
feat: add indexing pressure #727
Conversation
6086d54
to
c5cbb48
Compare
Signed-off-by: 黄振明 <[email protected]>
Signed-off-by: 黄振明 <[email protected]>
77d67c5
to
5885964
Compare
Signed-off-by: 黄振明 <[email protected]>
Signed-off-by: 黄振明 <[email protected]>
Signed-off-by: 黄振明 <[email protected]>
@SuperQ hello, Could you help to review this pr. I use this pr in our production, and everything is fine,
Please let me know if you have any questions or concerns. |
{ | ||
Type: prometheus.GaugeValue, | ||
Desc: prometheus.NewDesc( | ||
prometheus.BuildFQName(namespace, "indexing_pressure", "current_combined_coordinating_and_primary_in_bytes"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a composite metric that is the sum of the current_coordinating_in_bytes
and current_primary_in_bytes
metrics.
We typically drop these things to save space and cardinality when you can use foo + bar
in PromQL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for your review. After I check the document, current_combined_coordinating_and_primary_in_bytes
or total_combined_coordinating_and_primary_in_bytes
is not equal to coordinating + primary
. So maybe we should keep this? Here is the document:
# https://www.elastic.co/guide/en/elasticsearch/reference/current/cluster-nodes-stats.html#cluster-nodes-stats-api-response-body-indexing-pressure
combined_coordinating_and_primary_in_bytes:
(integer) Memory consumed, in bytes, by indexing requests in the coordinating or primary stage. This value is not the sum of coordinating and primary as a node can reuse the coordinating memory if the primary stage is executed locally.
Please let me known if you have any questions or concern.
So far, I have not seen the indexing_pressure metrics in the elasticsearch_exporter, so i add it. #638