Only register grpc TLS metrics on successful handshake #1338
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current gRPC implementation, TLS metrics are registered before the handshake is complete. In cases where the probe fails, probeSSLEarliestCertExpiryGauge is set to the default
time.Time
value (far in the past), resulting in any alerts usingprobe_ssl_earliest_cert_expiry
metric firing.In the case of the TLS handshake failing, it makes more sense for TLS metrics not to be set. This is the way the
http
probe is currently configured:blackbox_exporter/prober/http.go
Line 645 in 7e25c6f
This should also solve #1120.