forked from paritytech/polkadot-testnet-faucet
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upstream merge #4
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
forgetso
commented
Apr 26, 2024
- merge upstream changes
- bump to polkadot 10.13.1
- run txs in queue
Fixes paritytech#223 + Adding prom-client dependency, because it was removed from @eng-automation/js (rightfully so)
@josepot has reported an error with `@zombienet/[email protected]`, while the latest version worked
* Currently, e2e types are generated on postinstall and prebuild steps, which requires metadata to be available in Docker image, even though it's not technically used in the application code. I think separating things would make things more complicated, but it's possible. * Couldn't undestand the reason for having two different COPY instructions in Dockerfile, but that doesn't live well with generating types in postinstall, so merging those two * .scale metadata files from Zombienet hosts saved in the codebase, in order to be able to compile the code separately from running Zombienet
This removes the base url, making the website work on the root of the domain. Also, by doing this change, and having set up the dns, this resolves paritytech#348
It generates a JSON object inside the header following the instructions from: https://developers.google.com/search/docs/appearance/structured-data/faqpage It parses the information of the markdown text to generate this json object. This resolves paritytech#277
We currently don't have an artifact retention period, so it defaults to 90 days. While the artifact for the site is not too big, having one build per push and PR can quickly accumulate the amount and make us hit our hard limit. By adding a limit to the retention day of 5 days we ensure that we get rid of the old artifacts faster than waiting for two whole months. I also updated all the actions version to latest release
As the Frequency Faucet now also supports Frequency Paseo testnet in addition to the Rococo one, the url is being set to a generic one instead of specific for the network. https://faucet.testnet.frequency.xyz/
It fails when an external contributors make a PR. This will fix that issue.
Tests occasionally failing with polkadot-api/polkadot-api#320 This is an upstream bug in polkadot-sdk paritytech/polkadot-sdk#3658 Should be resolved when paritytech/polkadot-sdk#1516 is merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.