Adjust GitHub Actions for Ubuntu 24.04. #297
Conversation
GitHub migrated `ubuntu-latest` to `ubuntu-24.04`, which comes with a different set of pre-installed software. Most notably, both cargo audit and outdated tools are missing. Pin jobs to a specific version of the runner image to avoid another upgrade from breaking us in the future. Signed-off-by: Piotr Sikora <[email protected]>
| @@ -505,15 +494,6 @@ jobs: | |||
| - name: Format (manifest) | |||
| run: cargo verify-project | |||
|
|
|||
| - name: Run cargo audit | |||
There was a problem hiding this comment.
It looks like this PR removes auditing for both examples + reactors (though keeps the SDK itself cargo audited). Is that intended? If so, could you leave a comment as to express this happened and indicate that it is unnecessary?
There was a problem hiding this comment.
It's the same reasoning as to why they were excluded in local tests in #280 (i.e. the cost of building those tools doesn't provide too much value in examples, so it's not worth building them if they're not pre-installed as in full ubuntu-22.04 images on GitHub Actions).
With that in mind, I moved them to the audit and outdated jobs, since we build those tools for the SDK already.
Signed-off-by: Piotr Sikora <[email protected]>
Signed-off-by: Piotr Sikora <[email protected]>
Signed-off-by: Piotr Sikora <[email protected]>
.github/workflows/rust.yml
Outdated
| @@ -46,14 +46,17 @@ jobs: | |||
| ~/go/pkg/mod | |||
| key: licenses-${{ hashFiles('.github/workflows/rust.yml') }} | |||
|
|
|||
| - name: Check licenses | |||
| - name: Install dependencies | |||
| run: | | |||
| go install github.com/google/addlicense@latest | |||
There was a problem hiding this comment.
One thing that's bothering me is that the CI has been breaking lately due to updates to tools and build image.
I pinned the build image to ubuntu-24.04 in this PR, but should we also pin all the tools (addlicense, bazelisk, buildifier cargo-audit, cargo-outdated), and possibly even Rust toolchains for stable and nightly jobs (which would require more frequent PRs with version bumps)?
Signed-off-by: Piotr Sikora <[email protected]>
GitHub migrated
ubuntu-latesttoubuntu-24.04, which comes witha different set of pre-installed software. Most notably, both cargo
audit and outdated tools are missing.
Pin jobs to a specific version of the runner image to avoid another
upgrade from breaking us in the future.