Missing dialog windows

[Neustradamus]

Some dialog windows have been missing.

Examples:

"Psi: Join Groupchat":

• When we try to join a room where you are banned
• When we try to join a room where there is an user with same username
• When we try to join a room where rights are needed
• When we try to create a new room and room creation is denied by service policy
• When we try to join a room where the XMPP server is down
• When we try to join a room where the XMPP server has a problem of TLS certificate

In a MUC Room:

• When we try to send a private message and PM are disabled
• "Room Configuration": When we "Apply", no confirmation of validation of changes, we can lost management of the MUC Room...

In "Manage Bookmarks":

• No alert of not save changes, when we close the window. Currently, to have a save, it is needed to click on "OK".

Roster:

• When we try to send a message to a contact which the server is not online or server does not exist, no error message.

[Neustradamus]

<error type="cancel">
<not-allowed xmlns="urn:ietf:params:xml:ns:xmpp-stanzas"/>
<text xmlns="urn:ietf:params:xml:ns:xmpp-stanzas">Error handling test</text>
</error>

Linked to:

• Psi+ doesn't show message errors psi-plus/main#788

[Neustradamus]

Examples of errors which are not showed in Psi:

When we try to join a MUC Room from "Bookmarks Manager" or "Psi: Join Groupchat":

<error type="auth">
<forbidden xmlns="urn:ietf:params:xml:ns:xmpp-stanzas"/>
<text xmlns="urn:ietf:params:xml:ns:xmpp-stanzas" xml:lang="en">You have been banned from this room</text>
</error>

<error type="cancel" code="409">
<conflict xmlns="urn:ietf:params:xml:ns:xmpp-stanzas"/>
<text xmlns="urn:ietf:params:xml:ns:xmpp-stanzas">That nickname is already in use by another occupant</text>
</error>

<error type="cancel" code="409">
<conflict xmlns="urn:ietf:params:xml:ns:xmpp-stanzas"/>
<text xmlns="urn:ietf:params:xml:ns:xmpp-stanzas">The nickname that is being used is used by someone else.</text>
</error>

<error type="auth">
<registration-required xmlns="urn:ietf:params:xml:ns:xmpp-stanzas"/>
<text xmlns="urn:ietf:params:xml:ns:xmpp-stanzas" xml:lang="en">Membership is required to enter this room</text>
</error>

<error type="auth">
<forbidden xmlns="urn:ietf:params:xml:ns:xmpp-stanzas"/>
<text xmlns="urn:ietf:params:xml:ns:xmpp-stanzas" xml:lang="en">Room creation is denied by service policy</text>
</error>

<error type="auth" code="403">
<forbidden xmlns="urn:ietf:params:xml:ns:xmpp-stanzas"/>
<text xmlns="urn:ietf:params:xml:ns:xmpp-stanzas" xml:lang="en">Room creation is denied by service policy</text>
</error>

<error by="conference.domain.tld" type="cancel">
<not-allowed xmlns="urn:ietf:params:xml:ns:xmpp-stanzas"/>
<text xmlns="urn:ietf:params:xml:ns:xmpp-stanzas">Room creation is restricted</text>
</error>

<presence to="[email protected]/client" from="[email protected]/username" type="error">
<error by="domain1.tld" type="cancel">
<remote-server-not-found xmlns="urn:ietf:params:xml:ns:xmpp-stanzas"/>
<text xmlns="urn:ietf:params:xml:ns:xmpp-stanzas">Server-to-server connection failed: No route to host</text>
</error>
</presence>

<error by="domain.tld" type="cancel">
<remote-server-not-found xmlns="urn:ietf:params:xml:ns:xmpp-stanzas"/>
<text xmlns="urn:ietf:params:xml:ns:xmpp-stanzas">Server-to-server connection failed: connection timeout</text>
</error>

<error by="domain.tld" type="cancel">
<remote-server-not-found xmlns="urn:ietf:params:xml:ns:xmpp-stanzas"/>
<text xmlns="urn:ietf:params:xml:ns:xmpp-stanzas">Server-to-server connection failed: unable to resolve service</text>
</error>

When we are in MUC:

<error by="[email protected]" type="cancel">
<policy-violation xmlns="urn:ietf:params:xml:ns:xmpp-stanzas"/>
<text xmlns="urn:ietf:params:xml:ns:xmpp-stanzas">Private messages are disabled</text>
</error>