Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Psi+ doesn't show message errors #788

Open
mdosch opened this issue Oct 30, 2020 · 7 comments
Open

Psi+ doesn't show message errors #788

mdosch opened this issue Oct 30, 2020 · 7 comments

Comments

@mdosch
Copy link

mdosch commented Oct 30, 2020 •
edited
Loading

Version: 1.4.554 (debian)

When a message is not delivered, Psi+ doesn't show the error therefore you don't know that the message was not delivered (e.g. because it's rejected).

<message to='REDACTED/Psi+' type='error' id='aac9a' from='[email protected]' xml:lang='en'><error type='cancel'><not-allowed xmlns='urn:ietf:params:xml:ns:xmpp-stanzas'/><text xm
lns='urn:ietf:params:xml:ns:xmpp-stanzas'>Error handling test</text></error></message>

In this case I would expect to get an indication that the message delivery failed and the message Error handling test should be shown to the user. But nothing is shown:

2020-10-30-115151_scrot

You can use xmpp:[email protected] for testing as it will also reply with an error.
@tehnick
Copy link
Member

tehnick commented Oct 30, 2020

This is strange. As far as I see XEP-0086 is supported in Psi+:
https://github.com/psi-im/psi/wiki/Supported-XEPs

@mdosch
Copy link
Author

mdosch commented Oct 30, 2020 •
edited
Loading

Error codes are deprecated and stanza errors are defined in RFC6120.

@tehnick
Copy link
Member

tehnick commented Oct 30, 2020

Yeh, Psi+ supports a lot of deprecated things and does not support some of new ones...

@mdosch mdosch mentioned this issue Oct 30, 2020
Closed
@Neustradamus
Copy link

@Ri0n: Can you look this good @mdosch ticket?

In more, there is "reply with nonexistent account" too, specified in profanity-im ticket:

It is more a Psi ticket ^^

@Neustradamus Neustradamus mentioned this issue May 7, 2024
Open
@lao-mang
Copy link

lao-mang commented May 7, 2024 •
edited
Loading

да. ошибки не выводит

@Neustradamus
Copy link

There are two errors in this case:

<iq id='ID1' from='[email protected]' to='[email protected]' type='get'>
<pubsub xmlns='http://jabber.org/protocol/pubsub'>
<items node='eu.siacs.conversations.axolotl.devicelist'/>
</pubsub>
</iq>

<iq xml:lang="en" to="[email protected]/client" from="[email protected]" type="error" id="ID1">
<error type="auth">
<forbidden xmlns="urn:ietf:params:xml:ns:xmpp-stanzas"/>
</error>
</iq>

<message to="[email protected]" type="chat" id="ID2">
<body>test</body>
<active xmlns="http://jabber.org/protocol/chatstates"/>
<request xmlns="urn:xmpp:receipts"/>
<nick xmlns="http://jabber.org/protocol/nick">Neustradamus</nick>
<origin-id xmlns="urn:xmpp:sid:0" id="ID2"/>
</message>

<message xml:lang="en" to="[email protected]/client" from="[email protected]" type="error" id="ID2">
<error type="cancel">
<not-allowed xmlns="urn:ietf:params:xml:ns:xmpp-stanzas"/>
<text xmlns="urn:ietf:params:xml:ns:xmpp-stanzas">Error handling test</text>
</error>
</message>

Other errors are here:

@Neustradamus
Copy link

@mdosch: Your original error is now showed with this commit:

Not allowed.
The recipient or server does not allow any entity to perform the action.
Error handling test
------

Psi+ 1.5.1889:

@Ri0n: But not the PubSub error :/

<iq id='ID1' from='[email protected]' to='[email protected]' type='get'>
<pubsub xmlns='http://jabber.org/protocol/pubsub'>
<items node='eu.siacs.conversations.axolotl.devicelist'/>
</pubsub>
</iq>

<iq xml:lang="en" to="[email protected]/client" from="[email protected]" type="error" id="ID1">
<error type="auth">
<forbidden xmlns="urn:ietf:params:xml:ns:xmpp-stanzas"/>
</error>
</iq>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Neustradamus @tehnick @mdosch @lao-mang