-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
L11 support #31
L11 support #31
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Just one nit-pick here
.github/workflows/test.yml
Outdated
php: [ '7.4', '8.0', '8.1' ] | ||
laravel: [ '8', '9', '10' ] | ||
php: [ '7.4', '8.0', '8.1', '8.2' ] | ||
laravel: [ '8', '9', '10', '11' ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there anything compatible with PHP 8.3? We can test it against 8.3 I think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably no harm adding 8.3 -- I've pushed that change up.
I updated some dependencies but the older versions of Laravel and PHP don't seem to be playing nice. Not sure if you want to drop support for L8, L9, php 7.4 & 8.0? |
Good catch. Yeah my rule of thumb here is just keep PHP versions still maintained. |
composer.json
Outdated
@@ -4,14 +4,14 @@ | |||
"keywords": ["laravel", "framework", "UPS", "Laravel UPS Api", "Laravel-Ups-Api", "Pierre Tondereau", "Ptondereau"], | |||
"require": { | |||
"php": "^7.4.15 || ^8.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part need to be updated too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm thank you
Looking to get Laravel 11 support for this package .. hoping this PR gets you most of the way there.
I'm not too familiar with the
test.yml
workflows portion, but I updated it to what I thought may work. 🤞Thanks!