Add automated tests bringing the total to 206

* Add automated tests bringing the total to 206. * Verify there are no duplicate unbound Sling lifecycle functions in the DOM.
puckowski · Feb 11, 2024 · fb04089 · fb04089
1 parent 2f10cbb
commit fb04089
Showing 1 changed file with 182 additions and 0 deletions.
diff --git a/src/globalTests.js b/src/globalTests.js
@@ -9399,6 +9399,7 @@ export class GlobalTestRunner {
         };
 
         const fnSet = new Set();
+        const nodeSet = new Set();
         let hasDuplicates = false;
         let count = 0;
 
@@ -9410,6 +9411,13 @@ export class GlobalTestRunner {
 
         while (stack.length > 0) {
             const node = stack.pop();
+
+            if (node.id !== undefined && node.id !== null && nodeSet.has(node.id)) {
+                continue;
+            } else {
+                nodeSet.add(node.id);
+            }
+
             count++;
             const fn = node.slOnDestroyFn;
 
@@ -9440,6 +9448,180 @@ export class GlobalTestRunner {
         window.globalTestCount++;
     }
 
+    testRunLastUnboundDestroyFunctionReferenceNoDuplicates() {
+        const result = {
+            test: 'test there are no duplicate unbound destroy function references',
+            success: false,
+            message: ''
+        };
+
+        const fnSet = new Set();
+        const nodeSet = new Set();
+        let hasDuplicates = false;
+        let count = 0;
+
+        const stack = [];
+
+        for (const bodyChild of document.body.children) {
+            stack.push(bodyChild);
+        }
+
+        while (stack.length > 0) {
+            const node = stack.pop();
+
+            if (node.id !== undefined && node.id !== null && nodeSet.has(node.id)) {
+                continue;
+            } else {
+                nodeSet.add(node.id);
+            }
+
+            count++;
+            const fn = node.slUnboundOnDestroy;
+
+            if (fn !== undefined && fn !== null) {
+                console.log(fn);
+                console.log(node);
+
+                if (fnSet.has(fn)) {
+                    hasDuplicates = true;
+
+                    break;
+                } else {
+                    fnSet.add(fn);
+                }
+            }
+
+            if (hasDuplicates) {
+                break;
+            }
+
+            for (const child of node.children) {
+                stack.push(child);
+            }
+        }
+
+        console.log('Evaluated ' + count + ' nodes in body for duplicate unbound destroy functions');
+
+        result.success = !hasDuplicates;
+
+        window.globalTestResults.push(result);
+        window.globalTestCount++;
+    }
+
+    testRunLastAfterInitFunctionReferenceNoDuplicates() {
+        const result = {
+            test: 'test there are no duplicate unbound after init function references',
+            success: false,
+            message: ''
+        };
+
+        const fnSet = new Set();
+        const nodeSet = new Set();
+        let hasDuplicates = false;
+        let count = 0;
+
+        const stack = [];
+
+        for (const bodyChild of document.body.children) {
+            stack.push(bodyChild);
+        }
+
+        while (stack.length > 0) {
+            const node = stack.pop();
+
+            if (node.id !== undefined && node.id !== null && nodeSet.has(node.id)) {
+                continue;
+            } else {
+                nodeSet.add(node.id);
+            }
+
+            count++;
+            const fn = node.slUnboundAfterInit;
+
+            if (fn !== undefined && fn !== null) {
+                if (fnSet.has(fn)) {
+                    hasDuplicates = true;
+
+                    break;
+                } else {
+                    fnSet.add(fn);
+                }
+            }
+
+            if (hasDuplicates) {
+                break;
+            }
+
+            for (const child of node.children) {
+                stack.push(child);
+            }
+        }
+
+        console.log('Evaluated ' + count + ' nodes in body for duplicate unbound after init functions');
+
+        result.success = !hasDuplicates;
+
+        window.globalTestResults.push(result);
+        window.globalTestCount++;
+    }
+
+    testRunLastOnInitFunctionReferenceNoDuplicates() {
+        const result = {
+            test: 'test there are no duplicate unbound on init function references',
+            success: false,
+            message: ''
+        };
+
+        const fnSet = new Set();
+        const nodeSet = new Set();
+        let hasDuplicates = false;
+        let count = 0;
+
+        const stack = [];
+
+        for (const bodyChild of document.body.children) {
+            stack.push(bodyChild);
+        }
+
+        while (stack.length > 0) {
+            const node = stack.pop();
+
+            if (node.id !== undefined && node.id !== null && nodeSet.has(node.id)) {
+                continue;
+            } else {
+                nodeSet.add(node.id);
+            }
+
+            count++;
+            const fn = node.slUnboundOnInit;
+
+            if (fn !== undefined && fn !== null) {
+                if (fnSet.has(fn)) {
+                    hasDuplicates = true;
+
+                    break;
+                } else {
+                    fnSet.add(fn);
+                }
+            }
+
+            if (hasDuplicates) {
+                break;
+            }
+
+            for (const child of node.children) {
+                stack.push(child);
+            }
+        }
+
+        console.log('Evaluated ' + count + ' nodes in body for duplicate unbound on init functions');
+
+        result.success = !hasDuplicates;
+
+        window.globalTestResults.push(result);
+        window.globalTestCount++;
+    }
+
     testRunLastFunctionMapNoDuplicates() {
         const result = {
             test: 'test destroy function map contains no duplicates',