Remove deprecated ADDITIONAL_OCI_ARTIFACT_TYPES #1590
Conversation
git-hyagi
force-pushed
the
remove-deprecated-ADDITIONAL_OCI_ARTIFACT_TYPES
branch
from
846807e to
76f6a08
Compare
|
|
||
| .. _default-oci-types: | ||
|
|
||
| By default the following list of media types is enabled in the Container Registry:: |
There was a problem hiding this comment.
I would not remove entirely this file and leave a section in documentation stating that we are an OCI artifact registry. I would reword some of these docs with few examples what kind of additional to regular mediatypes we support ( out of the box) so it is clear for the end user that we are not just container but also artifact registry.
There was a problem hiding this comment.
How about we mention this information on our landing page (https://docs.pulpproject.org/pulp_container/)? I do not think it is necessary to have a dedicated page for it.
There was a problem hiding this comment.
I could be going both ways, however my preference would be to have it in a separate page for better readability and not cluttering the landing page
Example https://docs.docker.com/docker-hub/oci-artifacts/
There was a problem hiding this comment.
@git-hyagi, do you think we should keep this doc section? If so, we may want to revisit the paragraphs and state clearly that we support OCI Artifacts, e.g., by referencing helm charts and providing more insights into what a generic OCI Artifact might look like. Of course, omitting the removed setting.
There was a problem hiding this comment.
I am in favor of keeping this doc section and rewriting the paragraphs to make it clear that this not just a container registry.
ipanova
dismissed
their stale review
Did not mean to make it a blocking comment but my feedback still stands
lubosmj
dismissed
their stale review
It is still unclear whether we will leave docs/workflows/oci-artifacts.rst removed or not.
git-hyagi
force-pushed
the
remove-deprecated-ADDITIONAL_OCI_ARTIFACT_TYPES
branch
from
76f6a08 to
719dde5
Compare
closes: #1537