Add support for Replicate feature

[MichalPysik]

Pulp Container now supports the Replication feature.

closes #1648

[ipanova]

pulp container plugin contains 2 distribution types(regular and pull-thru), if we replicate one pulp to another then we will create only regular distribution type and ignore pull-thru cache ones, which is probably fine(?) because we will mirror its 'sub-distributions', thoughts?
As a result of this replication process, the replicated instance will contain only regular repos, remotes and distributions and it will work fine, just it will not be a complete replication of original pulp and definitely these 2 instances will not be interchangeable

[lubosmj]

Thanks for working on this! 🧑‍🍳 I left a couple of suggestions. It is so unfortunate that we cannot test the changes in our CI. In pulp_gem, we utilized domains to mock different Pulp instances.

---

Can you test what happens if a user wants to replicate a distribution that does not serve any content?

pulp container distribution create --name bla --base-path bla

Started background task /pulp/api/v3/tasks/018ff259-9cc2-7e12-882a-5f8cae23e223/
Done.
{
  "pulp_created": "2024-06-07T10:58:30.298313Z",
  "content_guard": "/pulp/api/v3/contentguards/core/content_redirect/018fedd3-7710-72da-b2bb-0a807a6a5cc2/",
  "name": "bla",
  "pulp_last_updated": "2024-06-07T10:58:30.298333Z",
  "pulp_labels": {},
  "repository": null,
  "hidden": false,
  "pulp_href": "/pulp/api/v3/distributions/container/container/018ff259-9d19-7b34-82d3-5287faaa60cf/",
  "base_path": "bla",
  "repository_version": null,
  "registry_path": "localhost:5001/bla",
  "remote": null,
  "namespace": "/pulp/api/v3/pulp_container/namespaces/018ff259-9c9c-79ae-a41a-7b4dacbda975/",
  "private": false,
  "description": null
}

[lubosmj]

Do we need to add the private attribute here? I assume yes: https://staging-docs.pulpproject.org/pulp_container/docs/admin/learn/rbac/?h=private#private-repositories, https://github.com/pulp/pulpcore/blob/02bb455315a17a39cb0d936a12a13fbbdb887bb3/pulpcore/app/replica.py#L190. Though, I am not sure how replicas work with users' permissions. Once a distribution is private, and no users' permissions were "replicated", only admins can access the distribution.

[ipanova]

we should replicate objects with same options, if it was private upstream then it should be private downstream. the admin will need to set proper permissions downstream

[MichalPysik]

and what about the description field which container distributions have?

[MichalPysik]

Thanks for working on this! 🧑‍🍳 I left a couple of suggestions. It is so unfortunate that we cannot test the changes in our CI. In pulp_gem, we utilized domains to mock different Pulp instances.

Can you test what happens if a user wants to replicate a distribution that does not serve any content?

pulp container distribution create --name bla --base-path bla

Started background task /pulp/api/v3/tasks/018ff259-9cc2-7e12-882a-5f8cae23e223/
Done.
{
  "pulp_created": "2024-06-07T10:58:30.298313Z",
  "content_guard": "/pulp/api/v3/contentguards/core/content_redirect/018fedd3-7710-72da-b2bb-0a807a6a5cc2/",
  "name": "bla",
  "pulp_last_updated": "2024-06-07T10:58:30.298333Z",
  "pulp_labels": {},
  "repository": null,
  "hidden": false,
  "pulp_href": "/pulp/api/v3/distributions/container/container/018ff259-9d19-7b34-82d3-5287faaa60cf/",
  "base_path": "bla",
  "repository_version": null,
  "registry_path": "localhost:5001/bla",
  "remote": null,
  "namespace": "/pulp/api/v3/pulp_container/namespaces/018ff259-9c9c-79ae-a41a-7b4dacbda975/",
  "private": false,
  "description": null
}

@lubosmj this happens:

Error: Task group /pulp/api/v3/task-groups/018ff2bd-dd87-7ce9-97c3-13b4d83c28a1/ has failed/canceled tasks: ''publication''

I guess there's a bug to be fixed

Edit: The bug has been killed, doesn't even move its legs anymore 🐛

[lubosmj]

Do you think we should bump up the minimal pulpcore requirement too? The only supported version we can benefit from is 3.49, after backporting the fix to older pulpcore versions. I added the backport label to https://github.com/pulp/pulpcore/pull/5465/files.