Sign ignores .sig, .att, .sbom #1660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubosmj
reviewed
Jun 12, 2024
pulp_container/app/tasks/sign.py
Outdated
Comment on lines
53
to
55
| Q(container_tag__endswith=".sig") | ||
| | Q(container_tag__endswith=".att") | ||
| | Q(container_tag__endswith=".sbom") |
There was a problem hiding this comment.
I wonder if there are any more types we would like to ignore. I could not find any while briefly googling the subject.
There was a problem hiding this comment.
instead of traversing into another table do it directly from the Tag.name on line 65
ipanova
requested changes
Jun 13, 2024
pulp_container/app/tasks/sign.py
Outdated
Comment on lines
53
to
55
| Q(container_tag__endswith=".sig") | ||
| | Q(container_tag__endswith=".att") | ||
| | Q(container_tag__endswith=".sbom") |
There was a problem hiding this comment.
instead of traversing into another table do it directly from the Tag.name on line 65
MichalPysik
force-pushed
the
sign_ignore
branch
4 times, most recently
from
4766943 to
72eda42
Compare
lubosmj
approved these changes
Jun 19, 2024
ipanova
approved these changes
Jun 19, 2024
MichalPysik
force-pushed
the
sign_ignore
branch
4 times, most recently
from
7274d8b to
7bd95e5
Compare
The signing tasks no longer signs cosign signatures, attestations and sboms (images that end with .sigg, .att, or .sbom) and ignores them instead. closes pulp#1347
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The signing tasks no longer signs cosign signatures, attestations and sboms (images that end with .sigg, .att, or .sbom) and ignores them instead.
closes #1347