Update CI files for branch 2.14 #1664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubosmj
force-pushed
the
update-ci/2.14
branch
2 times, most recently
from
5fe9534 to
03c3f86
Compare
lubosmj
reviewed
Jun 20, 2024
Comment on lines
286
to
287
| with suppress(Exception): | ||
| monitor_task(container_namespace_api.delete(distribution.namespace).task) |
There was a problem hiding this comment.
Inspired by https://github.com/pulp/pulpcore/blob/5721e58d94e15c56be30ab4a5b5db46bb74e746f/pulpcore/pytest_plugin.py#L901.
Previous implementation was not resilient to task failures, see: https://github.com/pulp/pulpcore/blob/3.24/pulpcore/tests/functional/__init__.py#L933. We no longer support 3.24 branch even though it is still being installed by the CI. 😞 Therefore, I decided to include the change from newer pulpcore versions in the plugin itself.
lubosmj
force-pushed
the
update-ci/2.14
branch
4 times, most recently
from
c8a6e86 to
9bd47da
Compare
[noissue]
lubosmj
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.