Validate settings before running Pulp instance #1671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichalPysik
force-pushed
the
validate_settings
branch
2 times, most recently
from
4fb8bc6 to
b81a6fe
Compare
MichalPysik
force-pushed
the
validate_settings
branch
from
b81a6fe to
ff74d08
Compare
MichalPysik
force-pushed
the
validate_settings
branch
21 times, most recently
from
9ae30af to
e9cc0a4
Compare
lubosmj
reviewed
Jun 27, 2024
lubosmj
reviewed
Jun 27, 2024
MichalPysik
force-pushed
the
validate_settings
branch
from
e9cc0a4 to
17612a6
Compare
lubosmj
approved these changes
Jun 28, 2024
There was a problem hiding this comment.
Tested manually. The following output is printed out:
[root@a3d3e4263785 /]# pulpcore-manager check --deploy
SystemCheckError: System check identified some issues:
ERRORS:
?: (pulp_container.E001) PRIVATE_KEY_PATH variable has to be set when token authentification is enabled
?: (pulp_container.E001) PUBLIC_KEY_PATH variable has to be set when token authentification is enabled
?: (pulp_container.E001) TOKEN_SERVER variable has to be set when token authentification is enabled
?: (pulp_container.E001) TOKEN_SIGNATURE_ALGORITHM variable has to be set when token authentification is enabled
...
The question mark suggests that there is no actual object causing the problem: https://github.com/django/django/blob/0fdcf1029cea2d43bd68c5270f48e0f7deab5e47/django/core/checks/messages.py#L25. I guess we are fine with it.
lubosmj
reviewed
Jun 28, 2024
MichalPysik
force-pushed
the
validate_settings
branch
2 times, most recently
from
efd7f8f to
4cfb9d8
Compare
When token authentization is enabled, 4 additional variables have to be set. The state of these variables is now checked, while properly informing the user, instead of relying on exceptions raised later during the instance's run. closes pulp#1550
MichalPysik
force-pushed
the
validate_settings
branch
from
4cfb9d8 to
9dcdca3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When token authentization is enabled, 4 additional variables have to be set. The state of these variables is now checked, while properly informing the user, instead of relying on exceptions raised later during the instance's run.
closes #1550