Fix a sync filtered cosign without sigstore issue #1760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubosmj
reviewed
Sep 6, 2024
CHANGES/1759.bugfix
Outdated
Comment on lines
1
to
2
| Fixed an issue where trying to sync a filtered content with cosign signature, from a remote | ||
| without sigstore, and defined as `signed_only: true` could fail sometimes. |
There was a problem hiding this comment.
Can we go for something along these lines?
Suggested change
| Fixed an issue where trying to sync a filtered content with cosign signature, from a remote | |
| without sigstore, and defined as `signed_only: true` could fail sometimes. | |
| Resolved an issue where syncing filtered content with a cosign signature from a remote source lacking Sigstore, and with signed_only: true enabled, could occasionally fail. |
git-hyagi
force-pushed
the
sync-filtered-cosign-issue
branch
from
6afb2f7 to
143d35d
Compare
lubosmj
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #1759