Makes CONTENT_ORIGIN not a required setting #6156
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkliban
force-pushed
the
content-origin-none
branch
from
0796e1b to
c5b6f5f
Compare
dkliban
force-pushed
the
content-origin-none
branch
from
c5b6f5f to
41f46c3
Compare
dkliban
force-pushed
the
content-origin-none
branch
from
41f46c3 to
6e35d29
Compare
mdellweg
reviewed
Jan 6, 2025
Comment on lines
-200
to
+203
| A required string containing the protocol, fqdn, and port where the content app is reachable by | ||
| A string containing the protocol, fqdn, and port where the content app is reachable by | ||
| users. This is used by `pulpcore` and various plugins when referring users to the content app. | ||
| For example if the API should refer users to content at using http to pulp.example.com on port | ||
| 24816, (the content default port), you would set: `https://pulp.example.com:24816`. | ||
| 24816, (the content default port), you would set: `http://pulp.example.com:24816`. The default is | ||
| `None`. When set to `None`, the API returns relative URLs (without the protocol, fqdn, and port). |
There was a problem hiding this comment.
Now this is off wrt formatting. It's neither break at 100 c nor one sentence per line.
|
This work transitioned from @dkliban to @git-hyagi who needs to handle the requested changes. Unfortunately we need to close this PR and reopen a new one from hyagi's branch due to him not being a pulp/core maintainer currently. I've put a note on the pulpcore meeting agenda requesting we add him, but for today closing this PR is our only option to move forward. |
|
new PR: #6175 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #5931