Update GitHub Actions workflows. #5099
Conversation
pulumi-bot
added
the
impact/no-changelog-required
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5099 +/- ##
=======================================
Coverage 24.46% 24.46%
=======================================
Files 361 361
Lines 144037 144037
=======================================
Hits 35243 35243
Misses 108696 108696
Partials 98 98 ☔ View full report in Codecov by Sentry. |
|
.mk/minimal schema is unhappy possibly with my latest ci-mgmt changes, having a look. |
| bin/darwin-amd64/$(PROVIDER): TARGET := darwin-amd64 | ||
| bin/darwin-arm64/$(PROVIDER): TARGET := darwin-arm64 | ||
| bin/windows-amd64/$(PROVIDER).exe: TARGET := windows-amd64 | ||
| bin/linux-amd64/$(PROVIDER): export GOOS := linux |
There was a problem hiding this comment.
I think I know what the problem is. The export GOOS bit got exported all the way to override the go generate call in minimal_schema.mk. I can repro locally if I run GOOS=linux go generate e.g. specify the wrong OS.
|
Needs #5107 |
Pull request was closed
This PR was automatically generated by the update-workflows-ecosystem-providers workflow in the pulumi/ci-mgmt repo, from commit 62fdb1f928969ade9cecbec1408c5ae5963edff2.