-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix passing in version on provider build #486
Conversation
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
7cb2c98
to
8afae3a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not spotting any problems per se, but this will be confusing: when a repository is onboarded to ci-mgmt usually these files are auto-generated:
.github/workflows/build_sdk.yml
Makefile may or may not be generated - it depends but we need to be clear which one it is. Assuming this repo has a custom Makefile.
sdk/java/build.gradle is usually automatically generated as well by the make java_sdk command.
The danger here is that if these are actually automatically generated, the manual changes might be lost next time this is done.
Is it supposed to be auto-generated every run or once upon onboarding? It's not regenerated every time today afaik
This is a custom Makefile, never generated afaik. Should I add a comment or something like that to make it explicit that it is? |
Perfect thanks for clarifying. So Makefile is custom. sdk/java/build.gradle is generated - all good apparently. This leaves .github/workflows/build_sdk.yml This file should be coming from ci-mgmt and as it evolves in ci-mgmt this repo should be getting an updated copy. Usually this happens in automated PRs like pulumi/pulumi-aws#5092 - this helps us avoid drift of these workflows across all providers. |
Ah, I see, good to know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #486 +/- ##
===========================
===========================
☔ View full report in Codecov by Sentry. |
Summary
Summary