Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix passing in version on provider build #486

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Conversation

IaroslavTitov
Copy link
Contributor

Summary

Summary

  • Tested build works locally and provider works as expected
  • Integ tests

@IaroslavTitov IaroslavTitov added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Jan 10, 2025
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

@IaroslavTitov IaroslavTitov marked this pull request as ready for review January 10, 2025 23:27
Copy link
Member

@t0yv0 t0yv0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not spotting any problems per se, but this will be confusing: when a repository is onboarded to ci-mgmt usually these files are auto-generated:

.github/workflows/build_sdk.yml

Makefile may or may not be generated - it depends but we need to be clear which one it is. Assuming this repo has a custom Makefile.

sdk/java/build.gradle is usually automatically generated as well by the make java_sdk command.

The danger here is that if these are actually automatically generated, the manual changes might be lost next time this is done.

@IaroslavTitov
Copy link
Contributor Author

build_sdk.yml

Is it supposed to be auto-generated every run or once upon onboarding? It's not regenerated every time today afaik
I had to edit that file because I added the missed --version into java sdk generation, so sdk/java/build.gradle is now generated with a different version string every time, and thus needed changes to be ignored

we need to be clear which one it is. Assuming this repo has a custom Makefile.

This is a custom Makefile, never generated afaik. Should I add a comment or something like that to make it explicit that it is?

@t0yv0
Copy link
Member

t0yv0 commented Jan 13, 2025

Perfect thanks for clarifying. So Makefile is custom. sdk/java/build.gradle is generated - all good apparently.

This leaves .github/workflows/build_sdk.yml

This file should be coming from ci-mgmt and as it evolves in ci-mgmt this repo should be getting an updated copy. Usually this happens in automated PRs like pulumi/pulumi-aws#5092 - this helps us avoid drift of these workflows across all providers.

@IaroslavTitov
Copy link
Contributor Author

This file should be coming from ci-mgmt and as it evolves in ci-mgmt this repo should be getting an updated copy.

Ah, I see, good to know!

@IaroslavTitov IaroslavTitov merged commit ff33846 into main Jan 13, 2025
24 checks passed
@IaroslavTitov IaroslavTitov deleted the iaro/version branch January 13, 2025 18:34
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (0cd0883) to head (8afae3a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@     Coverage Diff     @@
##   main   #486   +/-   ##
===========================
===========================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resource plugin version mismatch despite no conflicting binaries
2 participants