Resolve DMI ChassisType for Windows too #2501
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
|
yakatz
force-pushed
the
feature/windows_chassistype
branch
from
ff9eec6 to
783816a
Compare
Query dmi for chassis information on Windows also
yakatz
force-pushed
the
feature/windows_chassistype
branch
from
783816a to
1692fc8
Compare
joshcooper
reviewed
Jul 26, 2024
| module Facter | ||
| module Resolvers | ||
| class DMISystemEnclosure < BaseResolver | ||
| @log = Facter::Log.new(self) |
There was a problem hiding this comment.
It's no longer recommended/needed to create a log instance, see 0168116 Could you rebase on main and drop this line?
|
Going to close and reopen to rekick tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use the
dmi.chassis.typefact (as a poor way) to determine whether a system in compatible with Dell server management tools. No reason it shouldn't be available on Windows.