PE-38801 Task added to fetch rules for PE Infrastructure Agent group and warn user that they will be replaced #388
ci.yml
on: pull_request
Spec
/
Setup Test Matrix
31s
Matrix: Spec / spec
Matrix: Acceptance / acceptance
Waiting for pending jobs
Annotations
14 errors and 13 warnings
Spec / Spec tests (Puppet: ~> 8.0, Ruby Ver: 3.2):
spec/plans/convert_spec.rb#L15
peadm::convert single primary no dr valid
Failure/Error: expect(run_plan('peadm::convert', params)).to be_ok
expected `#<Bolt::PlanResult:0x00007f0e82daf060 @value=#<Bolt::PAL::PALError: JSON::ParserError>, @status="failure">.ok?` to be truthy, got false
|
Spec / Spec tests (Puppet: ~> 8.0, Ruby Ver: 3.2):
spec/plans/upgrade_spec.rb#L23
peadm::upgrade minimum variables to run
Failure/Error:
expect(run_plan('peadm::upgrade',
'primary_host' => 'primary',
'version' => '2021.7.9')).to be_ok
expected `#<Bolt::PlanResult:0x00007f0e8329c820 @value=#<Bolt::PAL::PALError: JSON::ParserError>, @status="failure">.ok?` to be truthy, got false
|
Spec / Spec tests (Puppet: ~> 8.0, Ruby Ver: 3.2):
spec/plans/upgrade_spec.rb#L37
peadm::upgrade runs with a primary, compilers, but no replica
Failure/Error:
expect(run_plan('peadm::upgrade',
'primary_host' => 'primary',
'compiler_hosts' => 'compiler',
'version' => '2021.7.9')).to be_ok
expected `#<Bolt::PlanResult:0x00007f0e827c8db8 @value=#<Bolt::PAL::PALError: JSON::ParserError>, @status="failure">.ok?` to be truthy, got false
|
Spec / Spec tests (Puppet: ~> 8.0, Ruby Ver: 3.2):
spec/plans/upgrade_spec.rb#L97
peadm::upgrade r10k_known_hosts updates pe.conf if r10k_known_hosts is set
Failure/Error:
expect(run_plan('peadm::upgrade',
'primary_host' => 'primary',
'version' => '2023.3.0',
'r10k_known_hosts' => r10k_known_hosts,
'permit_unsafe_versions' => true)).to be_ok
expected `#<Bolt::PlanResult:0x00007f0e8362aff0 @value=#<Bolt::PAL::PALError: JSON::ParserError>, @status="failure">.ok?` to be truthy, got false
|
Spec / Spec tests (Puppet: ~> 8.0, Ruby Ver: 3.2):
spec/plans/upgrade_spec.rb#L117
peadm::upgrade r10k_known_hosts warns if upgrading to 2023.3+ from 2023.0- without r10k_known_hosts set
Failure/Error:
expect(run_plan('peadm::upgrade',
'primary_host' => 'primary',
'version' => '2023.3.0',
'permit_unsafe_versions' => true)).to be_ok
RuntimeError:
Expected out::message to be called 1 times with parameters
WARNING: Starting in PE 2023.3, SSH host key verification is required for Code Manager and r10k.
To enable host key verification, you must define the puppet_enterprise::profile::master::r10k_known_hosts parameter with an array of hashes containing "name", "type", and "key" to specify your hostname, key type, and public key for your remote host(s).
If you currently use SSH protocol to allow r10k to access your remote Git repository, your Code Manager or r10k code management tool cannot function until you define the r10k_known_hosts parameter.
Please refer to the Puppet Enterprise 2023.3 Upgrade cautions for more details.
Plan result: {"kind":"bolt/pal-error","msg":"JSON::ParserError","details":{"file":"/home/runner/work/puppetlabs-peadm/puppetlabs-peadm/spec/fixtures/modules/peadm/plans/upgrade.pp","line":330,"column":47}}
/home/runner/work/puppetlabs-peadm/puppetlabs-peadm/vendor/bundle/ruby/3.2.0/gems/bolt-3.30.0/lib/bolt_spec/plans/action_stubs.rb:70:in `assert_called'
/home/runner/work/puppetlabs-peadm/puppetlabs-peadm/vendor/bundle/ruby/3.2.0/gems/bolt-3.30.0/lib/bolt_spec/plans/action_stubs.rb:24:in `block in assert_called'
/home/runner/work/puppetlabs-peadm/puppetlabs-peadm/vendor/bundle/ruby/3.2.0/gems/bolt-3.30.0/lib/bolt_spec/plans/action_stubs.rb:24:in `each'
/home/runner/work/puppetlabs-peadm/puppetlabs-peadm/vendor/bundle/ruby/3.2.0/gems/bolt-3.30.0/lib/bolt_spec/plans/action_stubs.rb:24:in `assert_called'
/home/runner/work/puppetlabs-peadm/puppetlabs-peadm/vendor/bundle/ruby/3.2.0/gems/bolt-3.30.0/lib/bolt_spec/plans/mock_executor.rb:191:in `assert_call_expectations'
/home/runner/work/puppetlabs-peadm/puppetlabs-peadm/vendor/bundle/ruby/3.2.0/gems/bolt-3.30.0/lib/bolt_spec/plans.rb:147:in `run_plan'
/home/runner/work/puppetlabs-peadm/puppetlabs-peadm/spec/plans/upgrade_spec.rb:121:in `block (3 levels) in <top (required)>'
/home/runner/work/puppetlabs-peadm/puppetlabs-peadm/vendor/bundle/ruby/3.2.0/gems/rspec-core-3.13.1/lib/rspec/core/example.rb:263:in `instance_exec'
/home/runner/work/puppetlabs-peadm/puppetlabs-peadm/vendor/bundle/ruby/3.2.0/gems/rspec-core-3.13.1/lib/rspec/core/example.rb:263:in `block in run'
/home/runner/work/puppetlabs-peadm/puppetlabs-peadm/vendor/bundle/ruby/3.2.0/gems/rspec-core-3.13.1/lib/rspec/core/example.rb:511:in `block in with_around_and_singleton_context_hooks'
/home/runner/work/puppetlabs-peadm/puppetlabs-peadm/vendor/bundle/ruby/3.2.0/gems/rspec-core-3.13.1/lib/rspec/core/example.rb:468:in `block in with_around_example_hooks'
/home/runner/work/puppetlabs-peadm/puppetlabs-peadm/vendor/bundle/ruby/3.2.0/gems/rspec-core-3.13.1/lib/rspec/core/hooks.rb:486:in `block in run'
/home/runner/work/puppetlabs-peadm/puppetlabs-peadm/vendor/bundle/ruby/3.2.0/gems/rspec-core-3.13.1/lib/rspec/core/hooks.rb:624:in `run_around_example_hooks_for'
/home/runner/work/puppetlabs-peadm/puppetlabs-peadm/vendor/bundle/ruby/3.2.0/gems/rspec-core-3.13.1/lib/rspec/core/hooks.rb:486:in `run'
/home/runner/work/puppetlabs-peadm/puppetlabs-peadm/vendor/bundle/ruby/3.2.0/gems/rspec-core-3.13.1/lib/rspec/core/example.rb:468:in `with_around_example_hooks'
/home/runner/work/puppetlabs-peadm/puppetlabs-peadm/vendor/bundle/ruby/3.2.0/gems/rspec-core-3.13.1/lib/rspec/core/example.rb:511:in `with_around_and_singleton_context_hooks'
/home/runner/work/puppetlabs-peadm/puppetlabs-peadm/vendor/bundle/ruby/3.2.0/gems/rspec-core-3.13.1/lib/rspec/core/example.rb:259:in `run'
/home/runner/work/puppetlabs-peadm/puppetlabs-peadm/vendor/bundle/ruby/3.2.0/gems/rspec-core-3.13.1/lib/rspec/core/example_group.rb:646:in `block in run_examples'
/home/runner/work/puppetlabs-peadm/puppet
|
Spec / Spec tests (Puppet: ~> 8.0, Ruby Ver: 3.2):
spec/plans/upgrade_spec.rb#L130
peadm::upgrade r10k_known_hosts upgrading from 2023.3+ does not warn if r10k_known_hosts is not set
Failure/Error:
expect(run_plan('peadm::upgrade',
'primary_host' => 'primary',
'version' => '2023.4.0',
'permit_unsafe_versions' => true)).to be_ok
expected `#<Bolt::PlanResult:0x00007f0e835c10f0 @value=#<Bolt::PAL::PALError: JSON::ParserError>, @status="failure">.ok?` to be truthy, got false
|
Spec / Spec tests (Puppet: ~> 8.0, Ruby Ver: 3.2)
Process completed with exit code 1.
|
Spec / Spec tests (Puppet: ~> 7.24, Ruby Ver: 2.7):
spec/plans/convert_spec.rb#L15
peadm::convert single primary no dr valid
Failure/Error: expect(run_plan('peadm::convert', params)).to be_ok
expected `#<Bolt::PlanResult:0x00005617a975bea0 @value=#<Bolt::PAL::PALError: JSON::ParserError>, @status="failure">.ok?` to be truthy, got false
|
Spec / Spec tests (Puppet: ~> 7.24, Ruby Ver: 2.7):
spec/plans/upgrade_spec.rb#L23
peadm::upgrade minimum variables to run
Failure/Error:
expect(run_plan('peadm::upgrade',
'primary_host' => 'primary',
'version' => '2021.7.9')).to be_ok
expected `#<Bolt::PlanResult:0x00005617a9803240 @value=#<Bolt::PAL::PALError: JSON::ParserError>, @status="failure">.ok?` to be truthy, got false
|
Spec / Spec tests (Puppet: ~> 7.24, Ruby Ver: 2.7):
spec/plans/upgrade_spec.rb#L37
peadm::upgrade runs with a primary, compilers, but no replica
Failure/Error:
expect(run_plan('peadm::upgrade',
'primary_host' => 'primary',
'compiler_hosts' => 'compiler',
'version' => '2021.7.9')).to be_ok
expected `#<Bolt::PlanResult:0x00005617a77be3e0 @value=#<Bolt::PAL::PALError: JSON::ParserError>, @status="failure">.ok?` to be truthy, got false
|
Spec / Spec tests (Puppet: ~> 7.24, Ruby Ver: 2.7):
spec/plans/upgrade_spec.rb#L97
peadm::upgrade r10k_known_hosts updates pe.conf if r10k_known_hosts is set
Failure/Error:
expect(run_plan('peadm::upgrade',
'primary_host' => 'primary',
'version' => '2023.3.0',
'r10k_known_hosts' => r10k_known_hosts,
'permit_unsafe_versions' => true)).to be_ok
expected `#<Bolt::PlanResult:0x00005617a978d810 @value=#<Bolt::PAL::PALError: JSON::ParserError>, @status="failure">.ok?` to be truthy, got false
|
Spec / Spec tests (Puppet: ~> 7.24, Ruby Ver: 2.7):
spec/plans/upgrade_spec.rb#L117
peadm::upgrade r10k_known_hosts warns if upgrading to 2023.3+ from 2023.0- without r10k_known_hosts set
Failure/Error:
expect(run_plan('peadm::upgrade',
'primary_host' => 'primary',
'version' => '2023.3.0',
'permit_unsafe_versions' => true)).to be_ok
RuntimeError:
Expected out::message to be called 1 times with parameters
WARNING: Starting in PE 2023.3, SSH host key verification is required for Code Manager and r10k.
To enable host key verification, you must define the puppet_enterprise::profile::master::r10k_known_hosts parameter with an array of hashes containing "name", "type", and "key" to specify your hostname, key type, and public key for your remote host(s).
If you currently use SSH protocol to allow r10k to access your remote Git repository, your Code Manager or r10k code management tool cannot function until you define the r10k_known_hosts parameter.
Please refer to the Puppet Enterprise 2023.3 Upgrade cautions for more details.
Plan result: {"kind":"bolt/pal-error","msg":"JSON::ParserError","details":{"file":"/home/runner/work/puppetlabs-peadm/puppetlabs-peadm/spec/fixtures/modules/peadm/plans/upgrade.pp","line":330,"column":47}}
/home/runner/work/puppetlabs-peadm/puppetlabs-peadm/vendor/bundle/ruby/2.7.0/gems/bolt-3.30.0/lib/bolt_spec/plans/action_stubs.rb:70:in `assert_called'
/home/runner/work/puppetlabs-peadm/puppetlabs-peadm/vendor/bundle/ruby/2.7.0/gems/bolt-3.30.0/lib/bolt_spec/plans/action_stubs.rb:24:in `block in assert_called'
/home/runner/work/puppetlabs-peadm/puppetlabs-peadm/vendor/bundle/ruby/2.7.0/gems/bolt-3.30.0/lib/bolt_spec/plans/action_stubs.rb:24:in `each'
/home/runner/work/puppetlabs-peadm/puppetlabs-peadm/vendor/bundle/ruby/2.7.0/gems/bolt-3.30.0/lib/bolt_spec/plans/action_stubs.rb:24:in `assert_called'
/home/runner/work/puppetlabs-peadm/puppetlabs-peadm/vendor/bundle/ruby/2.7.0/gems/bolt-3.30.0/lib/bolt_spec/plans/mock_executor.rb:191:in `assert_call_expectations'
/home/runner/work/puppetlabs-peadm/puppetlabs-peadm/vendor/bundle/ruby/2.7.0/gems/bolt-3.30.0/lib/bolt_spec/plans.rb:147:in `run_plan'
/home/runner/work/puppetlabs-peadm/puppetlabs-peadm/spec/plans/upgrade_spec.rb:121:in `block (3 levels) in <top (required)>'
/home/runner/work/puppetlabs-peadm/puppetlabs-peadm/vendor/bundle/ruby/2.7.0/gems/rspec-core-3.13.1/lib/rspec/core/example.rb:263:in `instance_exec'
/home/runner/work/puppetlabs-peadm/puppetlabs-peadm/vendor/bundle/ruby/2.7.0/gems/rspec-core-3.13.1/lib/rspec/core/example.rb:263:in `block in run'
/home/runner/work/puppetlabs-peadm/puppetlabs-peadm/vendor/bundle/ruby/2.7.0/gems/rspec-core-3.13.1/lib/rspec/core/example.rb:511:in `block in with_around_and_singleton_context_hooks'
/home/runner/work/puppetlabs-peadm/puppetlabs-peadm/vendor/bundle/ruby/2.7.0/gems/rspec-core-3.13.1/lib/rspec/core/example.rb:468:in `block in with_around_example_hooks'
/home/runner/work/puppetlabs-peadm/puppetlabs-peadm/vendor/bundle/ruby/2.7.0/gems/rspec-core-3.13.1/lib/rspec/core/hooks.rb:486:in `block in run'
/home/runner/work/puppetlabs-peadm/puppetlabs-peadm/vendor/bundle/ruby/2.7.0/gems/rspec-core-3.13.1/lib/rspec/core/hooks.rb:624:in `run_around_example_hooks_for'
/home/runner/work/puppetlabs-peadm/puppetlabs-peadm/vendor/bundle/ruby/2.7.0/gems/rspec-core-3.13.1/lib/rspec/core/hooks.rb:486:in `run'
/home/runner/work/puppetlabs-peadm/puppetlabs-peadm/vendor/bundle/ruby/2.7.0/gems/rspec-core-3.13.1/lib/rspec/core/example.rb:468:in `with_around_example_hooks'
/home/runner/work/puppetlabs-peadm/puppetlabs-peadm/vendor/bundle/ruby/2.7.0/gems/rspec-core-3.13.1/lib/rspec/core/example.rb:511:in `with_around_and_singleton_context_hooks'
/home/runner/work/puppetlabs-peadm/puppetlabs-peadm/vendor/bundle/ruby/2.7.0/gems/rspec-core-3.13.1/lib/rspec/core/example.rb:259:in `run'
/home/runner/work/puppetlabs-peadm/puppetlabs-peadm/vendor/bundle/ruby/2.7.0/gems/rspec-core-3.13.1/lib/rspec/core/example_group.rb:646:in `block in run_examples'
/home/runner/work/puppetlabs-peadm/puppet
|
Spec / Spec tests (Puppet: ~> 7.24, Ruby Ver: 2.7):
spec/plans/upgrade_spec.rb#L130
peadm::upgrade r10k_known_hosts upgrading from 2023.3+ does not warn if r10k_known_hosts is not set
Failure/Error:
expect(run_plan('peadm::upgrade',
'primary_host' => 'primary',
'version' => '2023.4.0',
'permit_unsafe_versions' => true)).to be_ok
expected `#<Bolt::PlanResult:0x00005617aa40f5c0 @value=#<Bolt::PAL::PALError: JSON::ParserError>, @status="failure">.ok?` to be truthy, got false
|
Spec / Spec tests (Puppet: ~> 7.24, Ruby Ver: 2.7)
Process completed with exit code 1.
|
Spec / Setup Test Matrix
Cannot find image for Amazon-2
|
Spec / Spec tests (Puppet: ~> 8.0, Ruby Ver: 3.2):
spec/functions/get_targets_spec.rb#L20
peadm::get_targets string arguments converts a string input to a Target array without count
Skipped: Being able to stub the get_targets() function
|
Spec / Spec tests (Puppet: ~> 8.0, Ruby Ver: 3.2):
spec/functions/get_targets_spec.rb#L24
peadm::get_targets string arguments converts a string input to a Target array with count
Skipped: Being able to stub the get_targets() function
|
Spec / Spec tests (Puppet: ~> 8.0, Ruby Ver: 3.2):
spec/functions/get_targets_spec.rb#L31
peadm::get_targets array arguments converts an array input to a Target array without count
Skipped: Being able to stub the get_targets() function
|
Spec / Spec tests (Puppet: ~> 8.0, Ruby Ver: 3.2):
spec/functions/get_targets_spec.rb#L35
peadm::get_targets array arguments converts an array input to a Target array with count
Skipped: Being able to stub the get_targets() function
|
Spec / Spec tests (Puppet: ~> 8.0, Ruby Ver: 3.2):
spec/functions/file_or_content_spec.rb#L16
peadm::file_or_content
Skipped: Temporarily skipped with xit
|
Spec / Spec tests (Puppet: ~> 8.0, Ruby Ver: 3.2):
spec/plans/util/sanitize_pg_pe_conf_spec.rb#L11
peadm::util::sanitize_pg_pe_conf Runs
Failure/Error: expect(run_plan('peadm::util::sanitize_pg_pe_conf', 'targets' => 'foo,bar', 'primary_host' => 'pe-server-d8b317-0.us-west1-a.c.davidsand.internal')).to be_ok
expected `#<Bolt::PlanResult:0x00007fc7270f34f8 @value=#<Bolt::PAL::PALError: no implicit conversion of Hash into String>, @status="failure">.ok?` to be truthy, got false
|
Spec / Spec tests (Puppet: ~> 7.24, Ruby Ver: 2.7):
spec/functions/get_targets_spec.rb#L20
peadm::get_targets string arguments converts a string input to a Target array without count
Skipped: Being able to stub the get_targets() function
|
Spec / Spec tests (Puppet: ~> 7.24, Ruby Ver: 2.7):
spec/functions/get_targets_spec.rb#L24
peadm::get_targets string arguments converts a string input to a Target array with count
Skipped: Being able to stub the get_targets() function
|
Spec / Spec tests (Puppet: ~> 7.24, Ruby Ver: 2.7):
spec/functions/get_targets_spec.rb#L31
peadm::get_targets array arguments converts an array input to a Target array without count
Skipped: Being able to stub the get_targets() function
|
Spec / Spec tests (Puppet: ~> 7.24, Ruby Ver: 2.7):
spec/functions/get_targets_spec.rb#L35
peadm::get_targets array arguments converts an array input to a Target array with count
Skipped: Being able to stub the get_targets() function
|
Spec / Spec tests (Puppet: ~> 7.24, Ruby Ver: 2.7):
spec/functions/file_or_content_spec.rb#L16
peadm::file_or_content
Skipped: Temporarily skipped with xit
|
Spec / Spec tests (Puppet: ~> 7.24, Ruby Ver: 2.7):
spec/plans/util/sanitize_pg_pe_conf_spec.rb#L11
peadm::util::sanitize_pg_pe_conf Runs
Failure/Error: expect(run_plan('peadm::util::sanitize_pg_pe_conf', 'targets' => 'foo,bar', 'primary_host' => 'pe-server-d8b317-0.us-west1-a.c.davidsand.internal')).to be_ok
expected `#<Bolt::PlanResult:0x0000557c32df5260 @value=#<Bolt::PAL::PALError: no implicit conversion of Hash into String>, @status="failure">.ok?` to be truthy, got false
|