Add support for bolt 4.x #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ragingra
reviewed
Dec 5, 2024
| @@ -6,7 +6,7 @@ | |||
| function peadm::assert_supported_bolt_version ( | |||
| # No arguments | |||
| ) >> Struct[{ 'supported' => Boolean }] { | |||
| $supported_bolt_version = '>= 3.17.0 < 4.0.0' | |||
| $supported_bolt_version = '>= 3.17.0 < 5.0.0' | |||
There was a problem hiding this comment.
Should we update the version in the gem file as well?
There was a problem hiding this comment.
I checked that before raising the PR, the Gemfile doesn't pin the version.
There was a problem hiding this comment.
Looks like CI is still pulling in v3.x of the bolt gem because of the puppet_litmus dependency. We're working on getting that updated ASAP.
If that can't be done in the next few days I've got a workaround we can add so that we're testing against Bolt 4
There was a problem hiding this comment.
Litmus updated for bolt4 now. Closing and reopening to rekick CI
ragingra
approved these changes
Dec 12, 2024
vchepkov
pushed a commit
to vchepkov/puppetlabs-peadm
that referenced
this pull request
Dec 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Provide a detailed description of all the changes present in this pull request.
Additional Context
Add any additional context about the problem here.
Related Issues (if any)
Mention any related issues or pull requests.
Checklist
Changes include test coverage?
Have you updated the documentation?