Use multiple top-level values for BuildInfo.purs #1130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should these changes be done in #1126? |
Oh, I saw this comment too late - that was a good option, but a new PR works too |
JordanMartinez
force-pushed
the
jam/update-build-info
branch
from
6c6567b to
bb5aee0
Compare
|
Helps to push to the right branch... |
|
@f-f Looks like we got a chicken-and-egg problem. I need to reference the new BuildInfo file to get the bootstrap build step to work, but doing so fails to build the initial code to run the tests. |
This reverts commit 41b8079.
|
Right - I think the correct procedure is:
@JordanMartinez please double check this 😄 |
|
That sounds correct to me. |
|
Great, let's go for it |
f-f
approved these changes
Dec 4, 2023
|
Tests fail though: https://github.com/purescript/spago/actions/runs/7090846490/job/19298707004 |
|
Ah I see - this is because I fixed the output of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Somewhat dependent on #1126 (adds tests). Fixes #1128.
Checklist:
READMEP.S.: the above checks are not compulsory to get a change merged, so you may skip them. However, taking care of them will result in less work for the maintainers and will be much appreciated 😊