Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for python 3.8 & add 3.13 #929

Merged
merged 7 commits into from
Jan 6, 2025
Merged

Drop support for python 3.8 & add 3.13 #929

merged 7 commits into from
Jan 6, 2025

Conversation

ItsDrike
Copy link
Member

@ItsDrike ItsDrike commented Jan 6, 2025

This PR drops support for the now EOL Python 3.8 (since 2024-09-06). Additionally, since we haven't done so yet, it also adds support for python 3.13 - moving the latest CI version & adding it to tox versions.

Additionally, this also performs some housekeeping tasks:

  • Remove deprecated ANN1XX ignores, these rules were deprecated by ruff and aren't enabled by default anymore, no need to be disabling them.
  • Run ruff format, which is apparently failing after this update, even though ruff itself wasn't updated here. Perhaps it's bacause the changed pythonVersion config value for ruff, though the suggested format change would work produce a working python syntax for 3.8 too, so I'm not sure why it only failed here.
  • Update cffi dependency, as the current version fails to build on MacOS with Python 3.13
  • Update requests dependency, as the currently installed version: 2.32.0 was marked as yanked, due to CVE-2024-35195.
  • Bump down the pythonVersion config value of pyright to the oldest supported version (3.9), for some reason, this was set to 3.10 - I think this was done because pyright didn't support checking for __future__.annotations before, and we decided we wanted to be able to utilize the newer typing syntax with it, so we used a more recent version to avoid the errors. However, since pyright does support __future__.annotations now, this can be dropped back down.

Note: #928 is currently blocked by this PR, as poetry 2.0 has dropped support for py 3.8

@ItsDrike ItsDrike added the area: dependencies Related to package dependencies label Jan 6, 2025
pyrightconfig.json Outdated Show resolved Hide resolved
@ItsDrike ItsDrike force-pushed the drop-38-add-313 branch 2 times, most recently from 642595c to e8f61d3 Compare January 6, 2025 21:05
Copy link
Member

@PerchunPak PerchunPak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ItsDrike ItsDrike merged commit 2600201 into master Jan 6, 2025
11 checks passed
@ItsDrike ItsDrike deleted the drop-38-add-313 branch January 6, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dependencies Related to package dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants