Merge pull request #200 from MarkDana/chisq_fix_overflow

fixed the np.prod overflow issue in Chisq test
py-why · Oct 21, 2024 · d450dd8 · d450dd8
2 parents 7924253 + e25df9c
commit d450dd8
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/causallearn/utils/cit.py b/causallearn/utils/cit.py
@@ -288,7 +288,7 @@ def _Fill3DCountTableByUnique(dataSXY, cardSXY):
         def _Fill3DCountTable(dataSXY, cardSXY):
             # about the threshold 1e5, see a rough performance example at:
             # https://gist.github.com/MarkDana/e7d9663a26091585eb6882170108485e#file-count-unique-in-array-performance-md
-            if np.prod(cardSXY) < CONST_BINCOUNT_UNIQUE_THRESHOLD: return _Fill3DCountTableByBincount(dataSXY, cardSXY)
+            if 0 < np.prod(cardSXY) < CONST_BINCOUNT_UNIQUE_THRESHOLD: return _Fill3DCountTableByBincount(dataSXY, cardSXY)
             return _Fill3DCountTableByUnique(dataSXY, cardSXY)
 
         def _CalculatePValue(cTables, eTables):