Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed indexing error in dag2pag #144

Merged
merged 1 commit into from
Oct 28, 2023
Merged

Conversation

PhilippFaller
Copy link
Contributor

The indices in the sepset may not be compatible with the indices used in the PAG, when ruleR3(PAG, sepset, ...) is called.
This is, because the indices in the sepset depend on the order of nodes.
On the other hand, the indices returned by the PAG.node_map()-call within ruleR3 depend on the order of observed_nodes, which is random, as nodes are converted to a set before being passed to the constructor of the PAG.

This pull request proposes a simple reindexing before the call of ruleR3 and ruleR4b.

Copy link
Collaborator

@zhi-yi-huang zhi-yi-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much!

@kunwuz
Copy link
Collaborator

kunwuz commented Oct 28, 2023

Thanks for your PR! And thanks so much @zhi-yi-huang for the prompt review :)

@kunwuz kunwuz merged commit 0901441 into py-why:main Oct 28, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants