Endpoint comparison: check only for Endpoint instances #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated files:
causallearn/graph/Endpoint.py: in the reloaded__eq__, replaceself.value == other.valuebyisinstance(other, Endpoint) and self.value == other.value.Related to:
The issue: #149 and earlier pr #109. In some of our codes, the Endpoint comparison is in the form of
get_end_point(...) == Endpoint.ARROW, while the first function may return None, instead of any Endpoint instances. This patch fixed this issue.Tests:
TestFCIcan now pass, and the issues mentioned in #149 are addressed.