-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additions to ruff rules #386
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #386 +/- ##
===========================================
+ Coverage 97.78% 97.88% +0.09%
===========================================
Files 43 43
Lines 2579 2598 +19
===========================================
+ Hits 2522 2543 +21
+ Misses 57 55 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @BradyPlanden! I am not sure about the drop in coverage however... maybe we can ignore that safely?
Thanks for the review @agriyakhetarpal, yes - those tests need a bit of thought to wrangle back in. Work for another PR. |
Description
Adds additional linting rules to ruff (deployed via pre-commit) and corresponding fixes.
Issue reference
Fixes #385
Review
Before you mark your PR as ready for review, please ensure that you've considered the following:
Type of change
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ nox -s tests
$ nox -s doctest
You can run integration tests, unit tests, and doctests together at once, using
$ nox -s quick
.Further checks:
Thank you for contributing to our project! Your efforts help us to deliver great software.