Attempt to drop our usage of lcov and do things with coverage.py #12289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex
force-pushed
the
coverage-gore
branch
2 times, most recently
from
e0960f0 to
2068d31
Compare
Hmm, not sure if/how we can address this. |
alex
force-pushed
the
coverage-gore
branch
4 times, most recently
from
c7ed0aa to
0dfe5c2
Compare
|
nedbat/coveragepy#1919 would allow cleaning this up some, but I'm not sure that should be a blocker for this |
reaperhulk
reviewed
Jan 23, 2025
|
|
||
| def main(*lcov_paths: str): | ||
| cov = coverage.Coverage() | ||
| # XXX: Nasty mucking in semi-public APIs |
There was a problem hiding this comment.
We don't need to do this if nedbat/coveragepy#1919 or something like it merges right?
reaperhulk
reviewed
Jan 23, 2025
Co-authored-by: Paul Kehrer <[email protected]>
reaperhulk
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.