Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mat_inverse method #97

Merged
merged 6 commits into from
Jan 8, 2025
Merged

Add mat_inverse method #97

merged 6 commits into from
Jan 8, 2025

Conversation

panxinmiao
Copy link
Contributor

Following @Korijn 's suggestion in pygfx/pygfx#919 (comment), added the mat_inverse method to pylinalg.

@panxinmiao panxinmiao requested a review from Korijn as a code owner January 7, 2025 10:24
pylinalg/matrix.py Outdated Show resolved Hide resolved
@Korijn
Copy link
Contributor

Korijn commented Jan 7, 2025

Nice work! Just need to address the merge conflicts and the one review comment, then we can merge. :)

pylinalg/matrix.py Outdated Show resolved Hide resolved
pylinalg/matrix.py Outdated Show resolved Hide resolved
Co-authored-by: Korijn van Golen <[email protected]>
@Korijn Korijn merged commit 65fc9a2 into pygfx:main Jan 8, 2025
10 checks passed
@almarklein
Copy link
Member

almarklein commented Jan 8, 2025

Nice work! A comment and a question:

  • The method option "manual" strikes me as a bit odd. It's not really manual, but pure Python.
  • Would it be good to use this new inv method internally? If I checked correctly, we (only) use it in vec_unproject()

@Korijn
Copy link
Contributor

Korijn commented Jan 8, 2025

  • The method option "manual" strikes me as a bit odd. It's not really manual, but pure Python.
  • Would it be good to use this new inv method internally? If I checked correctly, we (only) use it in vec_unproject()

Didn't think about that! I will release a patch.

@Korijn
Copy link
Contributor

Korijn commented Jan 10, 2025

Done in #100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants