Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move splot code to giddy #231

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

move splot code to giddy #231

wants to merge 3 commits into from

Conversation

martinfleis
Copy link
Member

This moves code that now lives in spot directly to giddy due to the planned sunsetting of splot. So far it is mostly copy&paste with minor modification of import paths.

A main question I have is what do you want to do with the functions that are not exposed as Rose methods now. Should I expose all or do you want to keep them separately as functions in a public plotting module?

@jGaboardi
Copy link
Member

cc @weikang9009

@weikang9009
Copy link
Member

I think it is a good idea to expose all plotting functionalities as Rose methods, similar to what was previously done for the two plotting functionalities (dynamic_lisa_rose as plot and dynamic_lisa_vectors as plot_vectors). Any thoughts @sjsrey ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants