Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMPAT: fix compatibility with scipy 1.15 #221

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Conversation

martinfleis
Copy link
Member

This should fix the CI errors we are seeing. Probably worth cutting a patch release.

@martinfleis martinfleis requested a review from knaaptime January 14, 2025 14:21
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 0.0%. Comparing base (f6fe42d) to head (46114ef).
Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
tobler/area_weighted/area_interpolate.py 0.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #221   +/-   ##
===================================
  Coverage   0.0%   0.0%           
===================================
  Files        13     14    +1     
  Lines       515    532   +17     
===================================
- Misses      515    532   +17     
Files with missing lines Coverage Δ
tobler/area_weighted/area_interpolate.py 0.0% <0.0%> (ø)

... and 1 file with indirect coverage changes

@knaaptime
Copy link
Member

nice. Also ran into a compat issue yesterday where we need to update h3.edge_length with https://uber.github.io/h3-py/api_verbose.html#h3.average_hexagon_edge_length when buffer=True in h3fy

@knaaptime knaaptime merged commit 6b7b13e into pysal:main Jan 14, 2025
8 of 9 checks passed
@martinfleis martinfleis deleted the nonzero branch January 14, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants