Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Interval type hint #828

Merged

Conversation

rahuliyer95
Copy link
Contributor

Pull Request Check List

  • Added tests for changed code.
  • Updated documentation for changed code.

Updated the interval method's type hint to return the correct type (either a pendulum.DateTime or pendulum.Date) using Generics

@Secrus
Copy link
Collaborator

Secrus commented Nov 21, 2024

Please rebase your changes with master

@rahuliyer95 rahuliyer95 force-pushed the feat/improve-interval-type-hint branch from 16a6295 to b555493 Compare November 21, 2024 14:27
@rahuliyer95
Copy link
Contributor Author

@Secrus done

Copy link

codspeed-hq bot commented Nov 22, 2024

CodSpeed Performance Report

Merging #828 will not alter performance

Comparing rahuliyer95:feat/improve-interval-type-hint (3cc91f5) with master (b84b976)

Summary

✅ 1 untouched benchmarks

@Secrus Secrus merged commit 51fb4c3 into python-pendulum:master Nov 24, 2024
18 checks passed
@rahuliyer95 rahuliyer95 deleted the feat/improve-interval-type-hint branch November 25, 2024 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants