Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use v3 of the CodSpeed action #875

Merged

Conversation

edgarrmondragon
Copy link
Contributor

@edgarrmondragon edgarrmondragon commented Jan 15, 2025

Pull Request Check List

Ubuntu 24.04, which recently became the default version for the ubuntu-latest label,
doesn't seem to be yet supported by the CodSpeed action v1:

Error: Failed to prepare environment: Error: Only Ubuntu 20.04 and 22.04 are supported for now

https://github.com/python-pendulum/pendulum/actions/runs/12788370535/job/35649510157?pr=874

  • Added tests for changed code.
  • Updated documentation for changed code.

@edgarrmondragon edgarrmondragon changed the title Run CodSpeed workflow on Ubuntu 22.04 Use v3 of the CodSpeed action Jan 15, 2025
@sdispater
Copy link
Collaborator

Thanks @edgarrmondragon. Can we do it without the changes to the lock file?

@edgarrmondragon
Copy link
Contributor Author

Thanks @edgarrmondragon. Can we do it without the changes to the lock file?

Yeah, CI was blocked by it but happy to revert that commit.

@sdispater
Copy link
Collaborator

Oh, my bad. The workflow is downloading Poetry v2 so yeah I think we need the lock update to unblock the situation. Sorry about that.

@Secrus
Copy link
Collaborator

Secrus commented Jan 15, 2025

@sdispater I have #874 open, we can stack the changes between those PRs.

@sdispater
Copy link
Collaborator

@Secrus Up to you which PR you want to prefer to make the changes

edgarrmondragon and others added 2 commits January 16, 2025 10:19
Ubuntu 24.04, which recently became the default version for the `ubuntu-latest` label,
doesn't seem to be yet supported by the CodSpeed action:

```
Error: Failed to prepare environment: Error: Only Ubuntu 20.04 and 22.04 are supported for now
```

https://github.com/python-pendulum/pendulum/actions/runs/12788370535/job/35649510157?pr=874
@Secrus Secrus force-pushed the codspeed-ubuntu-22.04 branch from 953a3bd to c63734d Compare January 16, 2025 09:19
Copy link

codspeed-hq bot commented Jan 16, 2025

CodSpeed Performance Report

Merging #875 will degrade performances by 91.59%

Comparing edgarrmondragon:codspeed-ubuntu-22.04 (c63734d) with master (09d815a)

🎉 Hooray! pytest-codspeed just leveled up to 3.0.0!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

❌ 1 regressions

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark master edgarrmondragon:codspeed-ubuntu-22.04 Change
test_parse_iso8601 1.2 ms 14.1 ms -91.59%

@Secrus
Copy link
Collaborator

Secrus commented Jan 16, 2025

@sdispater @edgarrmondragon
I pushed my changes into this PR and rebased it, squashing the previous commits. It should now be ready to be merged.
The codspeed comment is the same as we had before, results are borked because of a major version change so we can ignore that.

@Secrus Secrus mentioned this pull request Jan 16, 2025
@sdispater sdispater merged commit 7642246 into python-pendulum:master Jan 16, 2025
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants