-
-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use v3 of the CodSpeed action #875
Use v3 of the CodSpeed action #875
Conversation
Thanks @edgarrmondragon. Can we do it without the changes to the lock file? |
Yeah, CI was blocked by it but happy to revert that commit. |
Oh, my bad. The workflow is downloading Poetry v2 so yeah I think we need the lock update to unblock the situation. Sorry about that. |
@sdispater I have #874 open, we can stack the changes between those PRs. |
@Secrus Up to you which PR you want to prefer to make the changes |
Ubuntu 24.04, which recently became the default version for the `ubuntu-latest` label, doesn't seem to be yet supported by the CodSpeed action: ``` Error: Failed to prepare environment: Error: Only Ubuntu 20.04 and 22.04 are supported for now ``` https://github.com/python-pendulum/pendulum/actions/runs/12788370535/job/35649510157?pr=874
953a3bd
to
c63734d
Compare
CodSpeed Performance ReportMerging #875 will degrade performances by 91.59%Comparing 🎉 Hooray!
|
Benchmark | master |
edgarrmondragon:codspeed-ubuntu-22.04 |
Change | |
---|---|---|---|---|
❌ | test_parse_iso8601 |
1.2 ms | 14.1 ms | -91.59% |
@sdispater @edgarrmondragon |
Pull Request Check List
Ubuntu 24.04, which recently became the default version for the
ubuntu-latest
label,doesn't seem to be yet supported by the CodSpeed action v1:
https://github.com/python-pendulum/pendulum/actions/runs/12788370535/job/35649510157?pr=874