Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of using __ for positional only arguments #3151

Merged
merged 3 commits into from
Dec 18, 2024

Conversation

A5rocks
Copy link
Contributor

@A5rocks A5rocks commented Dec 10, 2024

Ruff started this in #3150. While the autofix it has is unsafe (and therefore won't happen in future versions so no need to make a bug report; astral-sh/ruff#14818), why not finish the job and resolve #3094.

@A5rocks A5rocks added the typing Adding static types to trio's interface label Dec 10, 2024
Copy link
Member

@jakkdl jakkdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jakkdl jakkdl added this pull request to the merge queue Dec 18, 2024
@jakkdl jakkdl removed this pull request from the merge queue due to a manual request Dec 18, 2024
@jakkdl jakkdl added this pull request to the merge queue Dec 18, 2024
Merged via the queue into python-trio:main with commit b914c84 Dec 18, 2024
39 checks passed
@A5rocks A5rocks deleted the finish-ruffs-job branch December 18, 2024 13:22
@@ -0,0 +1 @@
Switch to using PEP570 for positional-only arguments for `~trio.socket.SocketType`'s methods.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, Sphinx has a :pep: role that one can use for PEP links in RST.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

opened #3160

@jakkdl jakkdl mentioned this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
typing Adding static types to trio's interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update SocketType.recv (&other) signatures to use PEP570
4 participants