Replace strict_concatenate = True with extra_checks = True
#126391
Merged
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
requested review from
AlexWaygood
and removed request for
markshannon and
erlend-aasland
sobolevn
added
skip issue
skip news
needs backport to 3.13
AlexWaygood
reviewed
Nov 4, 2024
There was a problem hiding this comment.
Hmm... I think @hauntsaninja might be thinking of reversing this deprecation: see python/mypy#18070
|
I think that the main plan right now is to add these checks directly to Basically, we don't have any noticable negatives. |
|
Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 25, 2025
…nGH-126391) (cherry picked from commit cc4f0a2) Co-authored-by: sobolevn <[email protected]>
|
GH-129286 is a backport of this pull request to the 3.13 branch. |
sobolevn
added a commit
that referenced
this pull request
Jan 25, 2025
…GH-126391) (#129286) Replace `strict_concatenate = True` with `extra_checks = True` (GH-126391) (cherry picked from commit cc4f0a2) Co-authored-by: sobolevn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option was deprecated in mypy. See python/mypy#18103
Follow up to #126352