Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-126862: Use Py_ssize_t instead of int when processing the number of super-classes #127523

Merged
merged 3 commits into from
Jan 10, 2025
Merged

gh-126862: Use Py_ssize_t instead of int when processing the number of super-classes #127523

merged 3 commits into from
Jan 10, 2025

Conversation

picnixz
Copy link
Member

@picnixz picnixz commented Dec 2, 2024 •
edited by bedevere-app bot
Loading

@picnixz picnixz requested a review from markshannon as a code owner December 2, 2024 17:16
@picnixz picnixz requested a review from JelleZijlstra December 2, 2024 17:17
@bedevere-app bedevere-app bot mentioned this pull request Dec 2, 2024
Closed
@picnixz picnixz added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Dec 2, 2024
markshannon
markshannon approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@markshannon markshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it is possible to get anywhere near 231 classes, but better safe than sorry.

@JelleZijlstra JelleZijlstra enabled auto-merge (squash) January 10, 2025 03:09
@JelleZijlstra JelleZijlstra merged commit 2fcdc84 into python:main Jan 10, 2025
41 checks passed
@miss-islington-app
Copy link

Thanks @picnixz for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 10, 2025
@picnixz @miss-islington
pythongh-126862: Use Py_ssize_t instead of int when processing th…
2f5dcc4 
…e number of super-classes (pythonGH-127523)

(cherry picked from commit 2fcdc84)

Co-authored-by: Bénédikt Tran <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Jan 10, 2025

GH-128699 is a backport of this pull request to the 3.13 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 10, 2025
@picnixz @miss-islington
pythongh-126862: Use Py_ssize_t instead of int when processing th…
942c7a0 
…e number of super-classes (pythonGH-127523)

(cherry picked from commit 2fcdc84)

Co-authored-by: Bénédikt Tran <[email protected]>
@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jan 10, 2025
@bedevere-app
Copy link

bedevere-app bot commented Jan 10, 2025

GH-128700 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Jan 10, 2025
JelleZijlstra pushed a commit that referenced this pull request Jan 10, 2025
@miss-islington @picnixz
[3.12] gh-126862: Use Py_ssize_t instead of int when processing t…
b55c404 
…he number of super-classes (GH-127523) (#128700)

gh-126862: Use `Py_ssize_t` instead of `int` when processing the number of super-classes  (GH-127523)
(cherry picked from commit 2fcdc84)

Co-authored-by: Bénédikt Tran <[email protected]>
JelleZijlstra pushed a commit that referenced this pull request Jan 10, 2025
@miss-islington @picnixz
[3.13] gh-126862: Use Py_ssize_t instead of int when processing t…
5370ad1 
…he number of super-classes (GH-127523) (#128699)

gh-126862: Use `Py_ssize_t` instead of `int` when processing the number of super-classes  (GH-127523)
(cherry picked from commit 2fcdc84)

Co-authored-by: Bénédikt Tran <[email protected]>
@picnixz picnixz deleted the fix/core/typeobject-tail-contains-126862 branch January 11, 2025 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomasr8 tomasr8 tomasr8 left review comments

@markshannon markshannon markshannon approved these changes

@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@picnixz @tomasr8 @markshannon @JelleZijlstra