gh-128562: Fix tkinter widget instance name sometimes duplicated on inherited class

[Xiaokang2022]

• Issue: tkinter widget instance name sometimes duplicated on inherited class #128562

[ZeroIntensity]

Needs a test.

[ZeroIntensity]

This works, but it's a little hacky, and probably going to lead to some unexpected results. The more ideal solution would be to actually check if the autogenerated name exists and then adjust accordingly (e.g. label2 could become label2_2).

[Xiaokang2022]

The more ideal solution would be to actually check if the autogenerated name exists and then adjust accordingly

However, this will cause the _name of the original normal widgets to be changed, which may lead to other incompatibilities. I'd prefer to just modify the name of the inherited class.

I now think that if the class name ends with a number, then we might be best able to put a special tag (This tag cannot appear in the class name) after its name. This may be a better solution. (e.g. label2 -> label2$)

What do you think of this solution?

[Xiaokang2022]

I now think that if the class name ends with a number, then we might be best able to put a special tag (This tag cannot appear in the class name) after its name.

The existing test code requires that the name must be a valid identifier. So there may not be a way to do that.

I'm not quite sure what to do right now is the best thing to do. :(

Sorry, I read it wrong, the existing test code requires that name is not a valid identifier.