Allow redefinitions in except/else/finally #18515
Merged
+121
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sterliakov
commented
Jan 23, 2025
| @@ -274,7 +320,6 @@ def f() -> None: | |||
| # E: Incompatible types in assignment (expression has type "int", variable has type "TypeVar") | |||
| reveal_type(x) # N: Revealed type is "typing.TypeVar" | |||
| y = 1 | |||
| # NOTE: '"int" not callable' is due to test stubs | |||
There was a problem hiding this comment.
This note no longer applies, necessary stubs were connected in #17384.
This comment has been minimized.
This comment has been minimized.
A5rocks
reviewed
Jan 23, 2025
This comment has been minimized.
This comment has been minimized.
sobolevn
reviewed
Jan 24, 2025
| a = "" | ||
| a = fn_str(a) # E: Incompatible types in assignment (expression has type "int", variable has type "str") | ||
| fn_int(a) # E: Argument 1 to "fn_int" has incompatible type "str"; expected "int" | ||
| except: |
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
sobolevn
approved these changes
Jan 24, 2025
A5rocks
approved these changes
Jan 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18514.
Only
tryclause should be treated as fallible, this should not prevent--allow-redefinitionfrom working in other try clauses (except, else, finally).