Clarify why some module-level objects in typing have default values
#7037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
| @@ -33,7 +34,7 @@ def runtime_checkable(cls: _TC) -> _TC: ... | |||
|
|
|||
| # This alias for above is kept here for backwards compatibility. | |||
| runtime = runtime_checkable | |||
| Protocol: _SpecialForm = ... | |||
| Protocol: _SpecialForm | |||
There was a problem hiding this comment.
Can we re-export Protocol from typing?
There was a problem hiding this comment.
It's not over till mypy_primer sings, but it looks like we can!
|
I hate it when flake8 complains at me with error codes I introduced. |
…peshed into reorganise-typing
This comment has been minimized.
This comment has been minimized.
1 similar comment
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
|
I take it by your silence @JelleZijlstra that you're not a fan of this PR ;) shall I close it? |
|
Sorry, too many things to look at. I'll review it later today. |
Of course, sorry for nagging! No rush. |
This was referenced Jan 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One possible solution to the issue raised in #7036 (comment).
cc. @JelleZijlstra