Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Windows arm64 scripts from pytorch/builder #144317

Closed
wants to merge 12 commits into from

Conversation

iremyux
Copy link
Collaborator

@iremyux iremyux commented Jan 7, 2025

This PR moves the Windows Arm64 scripts from the builder repository to the main repository. The corresponding PR to pytorch/builder that removes them is here : pytorch/builder#2058

@iremyux iremyux requested a review from a team as a code owner January 7, 2025 07:05
Copy link

pytorch-bot bot commented Jan 7, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/144317

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 10da4d7 with merge base f52901a (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@seemethere
Copy link
Member

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 23, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 23, 2025 17:42 Inactive
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 23, 2025 17:42 Inactive
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 23, 2025 17:42 Inactive
@iremyux iremyux deleted the windows-arm64-scripts branch January 24, 2025 12:37
@afrittoli
Copy link
Collaborator

@iremyux I'm trying to find out where bootstrap_libuv originates from - it looks like it was added in the PR, in commit "- openblas, libuv and tests update" as I don't think it ever existed in pytorch/build.

The reason I'm asking is that I'm working on the conda removal project, and libuv is one of the packages that is pulled from conda. We could use the bootstrap_libuv.bat script to build libuv for the supported architectures and store the resulting binaries in GitHub artifact or S3 for re-use. I don't see where bootstrap_libuv is invoked today, do you know how the script is used today?

@ozanMSFT
Copy link
Collaborator

Hey @afrittoli ; We've created bootstrap_libuv.bat to build libuv from source code for Windows ARM64.

This is necessary because conda does not support Windows ARM64. We compile the binary from the source code using MSVC and then copy the binaries to the target to enable the USE_DISTRIBUTED functionality for the PyTorch on Windows ARM64. This functionality was previously missing in the pytorch/builder project.

In theory, bootstrap_libuv.bat could also be used for other platforms, but we have not tested it on Windows x64 or other systems.

If possible, uploading it to an S3 Bucket or GitHub Artifact would be very helpful, allowing us to include it without rebuilding.

Regarding the usage:
Currently, we are updating and preparing Windows ARM64 workflows that will use these scripts. Once merged, these scripts will be used for the PyTorch Windows ARM64 distribution.

@afrittoli
Copy link
Collaborator

Hey @afrittoli ; We've created bootstrap_libuv.bat to build libuv from source code for Windows ARM64.

This is necessary because conda does not support Windows ARM64. We compile the binary from the source code using MSVC and then copy the binaries to the target to enable the USE_DISTRIBUTED functionality for the PyTorch on Windows ARM64. This functionality was previously missing in the pytorch/builder project.

In theory, bootstrap_libuv.bat could also be used for other platforms, but we have not tested it on Windows x64 or other systems.

If possible, uploading it to an S3 Bucket or GitHub Artifact would be very helpful, allowing us to include it without rebuilding.

Regarding the usage: Currently, we are updating and preparing Windows ARM64 workflows that will use these scripts. Once merged, these scripts will be used for the PyTorch Windows ARM64 distribution.

Cool, thanks.
I think it would make sense to streamline things and have both architectures use the same set of scripts, building from source and caching artefacts, rather than relying on coda for the amd64 case. @atalman WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: build release notes category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants