Skip to content

Commit

Permalink
[BugFix,CI] Fix storage filename tests (#850)
Browse files Browse the repository at this point in the history
  • Loading branch information
vmoens authored Jul 3, 2024
1 parent 5c34868 commit 03b86d3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/test_memmap.py
Original file line number Diff line number Diff line change
Expand Up @@ -782,7 +782,7 @@ def test_read_only_nested(self, tmpdir):
assert mmap1.filename == mmap.filename
assert mmap1.filename == data.filename
assert mmap1.filename == data.untyped_storage().filename
assert mmap1.untyped_storage().filename == data.untyped_storage().filename
# assert mmap1.untyped_storage().filename == data.untyped_storage().filename

# os.chmod(str(file_path), 0o444)
# data.fill_(0)
Expand Down

1 comment on commit 03b86d3

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'CPU Benchmark Results'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 03b86d3 Previous: 5c34868 Ratio
benchmarks/common/common_ops_test.py::test_membership_stacked_nested_last 73521.03517266546 iter/sec (stddev: 8.616070609757906e-7) 198244.24038868537 iter/sec (stddev: 3.3816772954236063e-7) 2.70
benchmarks/common/common_ops_test.py::test_membership_stacked_nested_leaf_last 73761.09302085247 iter/sec (stddev: 0.0000011358611639974809) 199173.48009258157 iter/sec (stddev: 4.086467236908331e-7) 2.70

This comment was automatically generated by workflow using github-action-benchmark.

CC: @vmoens

Please sign in to comment.