[Quality] fix c++ binaries formatting (#859)

tensordict/csrc/utils.cpp

@@ -0,0 +1,76 @@
+// Copyright (c) Meta Platforms, Inc. and affiliates.
+//
+// This source code is licensed under the MIT license found in the
+// LICENSE file in the root directory of this source tree.
+
+#include "utils.h"
+
+namespace py = pybind11;
+
+py::tuple _unravel_key_to_tuple(const py::object &key) {
+  bool is_tuple = py::isinstance<py::tuple>(key);
+  bool is_str = py::isinstance<py::str>(key);
+
+  if (is_tuple) {
+    py::list newkey;
+    for (const auto &subkey : key) {
+      if (py::isinstance<py::str>(subkey)) {
+        newkey.append(subkey);
+      } else {
+        auto _key = _unravel_key_to_tuple(subkey.cast<py::object>());
+        if (_key.size() == 0) {
+          return py::make_tuple();
+        }
+        newkey += _key;
+      }
+    }
+    return py::tuple(newkey);
+  }
+  if (is_str) {
+    return py::make_tuple(key);
+  } else {
+    return py::make_tuple();
+  }
+}
+
+py::object unravel_key(const py::object &key) {
+  bool is_tuple = py::isinstance<py::tuple>(key);
+  bool is_str = py::isinstance<py::str>(key);
+
+  if (is_tuple) {
+    py::list newkey;
+    int count = 0;
+    for (const auto &subkey : key) {
+      if (py::isinstance<py::str>(subkey)) {
+        newkey.append(subkey);
+        count++;
+      } else {
+        auto _key = _unravel_key_to_tuple(subkey.cast<py::object>());
+        count += _key.size();
+        newkey += _key;
+      }
+    }
+    if (count == 1) {
+      return newkey[0];
+    }
+    return py::tuple(newkey);
+  }
+  if (is_str) {
+    return key;
+  } else {
+    throw std::runtime_error("key should be a Sequence<NestedKey>");
+  }
+}
+
+py::list unravel_key_list(const py::list &keys) {
+  py::list newkeys;
+  for (const auto &key : keys) {
+    auto _key = unravel_key(key.cast<py::object>());
+    newkeys.append(_key);
+  }
+  return newkeys;
+}
+
+py::list unravel_key_list(const py::tuple &keys) {
+  return unravel_key_list(py::list(keys));
+}

tensordict/csrc/utils.h

@@ -8,70 +8,10 @@
 
 namespace py = pybind11;
 
-py::tuple _unravel_key_to_tuple(const py::object &key) {
-  bool is_tuple = py::isinstance<py::tuple>(key);
-  bool is_str = py::isinstance<py::str>(key);
+py::tuple _unravel_key_to_tuple(const py::object &key);
 
-  if (is_tuple) {
-    py::list newkey;
-    for (const auto &subkey : key) {
-      if (py::isinstance<py::str>(subkey)) {
-        newkey.append(subkey);
-      } else {
-        auto _key = _unravel_key_to_tuple(subkey.cast<py::object>());
-        if (_key.size() == 0) {
-          return py::make_tuple();
-        }
-        newkey += _key;
-      }
-    }
-    return py::tuple(newkey);
-  }
-  if (is_str) {
-    return py::make_tuple(key);
-  } else {
-    return py::make_tuple();
-  }
-}
+py::object unravel_key(const py::object &key);
 
-py::object unravel_key(const py::object &key) {
-  bool is_tuple = py::isinstance<py::tuple>(key);
-  bool is_str = py::isinstance<py::str>(key);
+py::list unravel_key_list(const py::list &keys);
 
-  if (is_tuple) {
-    py::list newkey;
-    int count = 0;
-    for (const auto &subkey : key) {
-      if (py::isinstance<py::str>(subkey)) {
-        newkey.append(subkey);
-        count++;
-      } else {
-        auto _key = _unravel_key_to_tuple(subkey.cast<py::object>());
-        count += _key.size();
-        newkey += _key;
-      }
-    }
-    if (count == 1) {
-      return newkey[0];
-    }
-    return py::tuple(newkey);
-  }
-  if (is_str) {
-    return key;
-  } else {
-    throw std::runtime_error("key should be a Sequence<NestedKey>");
-  }
-}
-
-py::list unravel_key_list(const py::list &keys) {
-  py::list newkeys;
-  for (const auto &key : keys) {
-    auto _key = unravel_key(key.cast<py::object>());
-    newkeys.append(_key);
-  }
-  return newkeys;
-}
-
-py::list unravel_key_list(const py::tuple &keys) {
-  return unravel_key_list(py::list(keys));
-}
+py::list unravel_key_list(const py::tuple &keys);