Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Compile - benchmarks #883

Merged
merged 10 commits into from
Jul 15, 2024
Merged

[Feature] Compile - benchmarks #883

merged 10 commits into from
Jul 15, 2024

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Jul 12, 2024 •
edited
Loading

Stack from ghstack (oldest at bottom):

@vmoens
Update
c8b9659 
[ghstack-poisoned]
This was referenced Jul 12, 2024
Merged
Merged
vmoens added a commit that referenced this pull request Jul 12, 2024
@vmoens
[Feature] Compile - benchmarks
5a4da8b 
ghstack-source-id: 6d922a0e2a7864454fc37a5f0af2e5a6ef3da3b1
Pull Request resolved: #883
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 12, 2024
vmoens added a commit that referenced this pull request Jul 12, 2024
@vmoens
[Feature] Compile - benchmarks
da4e668 
ghstack-source-id: 6d922a0e2a7864454fc37a5f0af2e5a6ef3da3b1
Pull Request resolved: #883
@vmoens
Update
11c2fb8 
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Jul 12, 2024
@vmoens
[Feature] Compile - benchmarks
8065dac 
ghstack-source-id: 6f463077f5c78b293419f45a422be2a1130739aa
Pull Request resolved: #883
@vmoens
Update
a97bd8a 
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Jul 15, 2024
@vmoens
[Feature] Compile - benchmarks
8c4e2cc 
ghstack-source-id: 09ec80b3493b3feaec9918236bba684afe486d1f
Pull Request resolved: #883
@vmoens
Update
b8d83c1 
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Jul 15, 2024
@vmoens
[Feature] Compile - benchmarks
c2226dd 
ghstack-source-id: 81507fc3ee3010819baecfc4b6e9ea7c72bd8520
Pull Request resolved: #883
@vmoens
Update
6301878 
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Jul 15, 2024
@vmoens
[Feature] Compile - benchmarks
78dc920 
ghstack-source-id: c70a71282557df15357de3bbd88b13440daac679
Pull Request resolved: #883
@vmoens
Update
51f2d48 
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Jul 15, 2024
@vmoens
[Feature] Compile - benchmarks
ddd83cc 
ghstack-source-id: 1fc36b58c136671d944cda39b86f3defa334bc21
Pull Request resolved: #883
vmoens added a commit that referenced this pull request Jul 15, 2024
@vmoens
[Feature] Compile - benchmarks
77051f0 
ghstack-source-id: 1fc36b58c136671d944cda39b86f3defa334bc21
Pull Request resolved: #883
@vmoens vmoens added the enhancement New feature or request label Jul 15, 2024
@vmoens vmoens linked an issue Jul 15, 2024 that may be closed by this pull request
Any plans to make it compatible with torch.jit? #532
Closed
@vmoens
Update
e080e43 
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Jul 15, 2024
@vmoens
[Feature] Compile - benchmarks
5992ce4 
ghstack-source-id: b1a98081ccca627cdb34338594f8cac2a7473fcd
Pull Request resolved: #883
@vmoens
Copy link
Contributor Author

vmoens commented Jul 15, 2024

@jisaacso this is the last PR of the compile stack

It includes benchmarks for tensordict vs pytree in eager and compile. Ops like copy (test: test_compile_copy_flat) run faster in eager and compile with TD compared to pytree.

@vmoens
Update
9a3cf4e 
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Jul 15, 2024
@vmoens
[Feature] Compile - benchmarks
f49319d 
ghstack-source-id: d3eccd1e9791b707fa0f23d0d87997445d678cd9
Pull Request resolved: #883
@vmoens
Update
cb14899 
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Jul 15, 2024
@vmoens
[Feature] Compile - benchmarks
f07f3ef 
ghstack-source-id: e668eb7d2ae69ee94b75c2cfb1c0a9add0f04712
Pull Request resolved: #883
@vmoens
Update
8f25580 
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Jul 15, 2024
@vmoens
[Feature] Compile - benchmarks
feea0da 
ghstack-source-id: b362c3b9688f173fd85004abf8dc417936daafcc
Pull Request resolved: #883
@vmoens vmoens merged commit 8f25580 into gh/vmoens/10/base Jul 15, 2024
21 of 31 checks passed
vmoens added a commit that referenced this pull request Jul 15, 2024
@vmoens
[Feature] Compile - benchmarks
4a02d92 
ghstack-source-id: b362c3b9688f173fd85004abf8dc417936daafcc
Pull Request resolved: #883
@vmoens vmoens deleted the gh/vmoens/10/head branch July 15, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Any plans to make it compatible with torch.jit?
2 participants
@vmoens @facebook-github-bot