Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return dynamics's generators from Model #216

Closed
wants to merge 2 commits into from

Conversation

frosati1
Copy link
Collaborator

What

Ideally reinserts lindbladian evolution

Why

Linbladian evolution was in the code but not accessible.
Reduces code complexity and nested ifs.
Closes Issue #215

How

A new function in the Model takes care of returning Hamiltonians or Liouvillian superoperators according to model.lindbladian.
In this way propagation.pwc() basically just needs to do the exponentiation.

Remarks

Checks on signals (e. g. passing times) are supposed to be moved to the Generator and might be faulty now.

Checklist

Please include and complete the following checklist. Your Pull Request is (in most cases) not ready for review until the following have been completed. You can create a draft PR while you are still completing the checklist. Check the Contribution Guidelines for more details. You can mark an item as complete with the - [x] prefix

  • Tests - Added unit tests for new code, regression tests for bugs and updated the integration tests if required
  • Formatting & Linting - black and flake8 have been used to ensure styling guidelines are met
  • Type Annotations - All new code has been type annotated in the function signatures using type hints
  • Docstrings - Docstrings have been provided for functions in the numpydoc style
  • Documentation - The tutorial style documentation has been updated to explain changes & new features
  • Notebooks - Example notebooks have been updated to incorporate changes and new features
  • Changelog - A short note on this PR has been added to the Upcoming Release section

@frosati1 frosati1 changed the title ts calculated in Exp and returning dynamics's generators from model Return dynamics's generators from Model Jun 15, 2022
@frosati1 frosati1 closed this Jul 15, 2022
@frosati1
Copy link
Collaborator Author

Goes on with @SRaent PR, I delete this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant