Return dynamics's generators from Model #216
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Ideally reinserts lindbladian evolution
Why
Linbladian evolution was in the code but not accessible.
Reduces code complexity and nested ifs.
Closes Issue #215
How
A new function in the Model takes care of returning Hamiltonians or Liouvillian superoperators according to model.lindbladian.
In this way propagation.pwc() basically just needs to do the exponentiation.
Remarks
Checks on signals (e. g. passing times) are supposed to be moved to the Generator and might be faulty now.
Checklist
Please include and complete the following checklist. Your Pull Request is (in most cases) not ready for review until the following have been completed. You can create a draft PR while you are still completing the checklist. Check the Contribution Guidelines for more details. You can mark an item as complete with the
- [x]
prefixblack
andflake8
have been used to ensure styling guidelines are metnumpydoc
style