-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resurrect Lindblad Evolution and Add Sequential Propagation #221
base: dev
Are you sure you want to change the base?
Conversation
…ests by only executing them in eager mode
Moritz Schu seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This pull request introduces 1 alert when merging 4f50fef into 003824c - view on LGTM.com new alerts:
|
Codecov Report
@@ Coverage Diff @@
## dev #221 +/- ##
==========================================
- Coverage 74.79% 74.02% -0.78%
==========================================
Files 38 38
Lines 5559 5597 +38
==========================================
- Hits 4158 4143 -15
- Misses 1401 1454 +53
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This pull request introduces 2 alerts when merging c6e109e into 003824c - view on LGTM.com new alerts:
|
@SRaent Can you add tests for the lindbladian evolution? In the future we would want to know if some work done elsewhere breaks this important functionality. |
What
Ideally reinserts lindbladian evolution
Added sequential propagators that use less ram
Why
Linbladian evolution was in the code but not accessible.
Reduces code complexity and nested ifs.
Closes Issue #215
How
A new function in the Model takes care of returning Hamiltonians or Liouvillian superoperators according to model.lindbladian.
In this way propagation.pwc() basically just needs to do the exponentiation.
Remarks
Checks on signals (e. g. passing times) are supposed to be moved to the Generator and might be faulty now.
Checklist
Please include and complete the following checklist. Your Pull Request is (in most cases) not ready for review until the following have been completed. You can create a draft PR while you are still completing the checklist. Check the Contribution Guidelines for more details. You can mark an item as complete with the
- [x]
prefixblack
andflake8
have been used to ensure styling guidelines are metnumpydoc
style