Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg] Enable kea and freexl drivers for GDAL #60201

Merged
merged 1 commit into from
Jan 21, 2025
+2 −1
Merged

[vcpkg] Enable kea and freexl drivers for GDAL #60201

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion vcpkg/vcpkg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,9 @@
"expat",
{
"name": "gdal",
"default-features": false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to see this! I was hesitating to propose this because I was not sure how works the default-feature/recommended-feature override here and there

Btw, Is this normal ?

So far, QGIS was not able to open Geopackage because sqlite was missing because of this line

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mixed bag of questions:

  1. default-features were already enabled so far whenever built with bindings, because in the bindings dependency, default-features was not deactivated. This is not expected and actually the change that we want here.
  2. The decision what's a default feature for gdal is not taken in here, this is mostly a copy of the upstream gdal port with some adjustments for python. Let's not dive into technicalities how it's implemented.
  3. I would like to get rid of our gdal overlay and replace it with a gdal-python port which only builds python bindings on top of an existing gdal installation. Similar to how gdal allows to build standalone plugins for some formats. I am not 100% sure this will work but it would ease our maintenance effort.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I understand it better, thanks 👍

"features": [
"freexl",
"kea",
troopa81 marked this conversation as resolved.
Show resolved Hide resolved
"poppler"
]
},
Expand Down
Loading